Skip to content

Conversation

@emkornfield
Copy link
Collaborator

@emkornfield emkornfield commented Oct 22, 2025

🥞 Stacked PR

Use this link to review incremental changes.


Rename schema's for more accurately describe schemas. This is follow-up from #1407

@github-actions github-actions bot added the breaking-change Change that require a major version bump label Oct 22, 2025
Copy link
Member

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops actually looks like this schema includes the CommitMetadata action which is only allowed in V2 checkpoints. should we just remove that from this schema and ensure it's in the 'all actions' one?

@emkornfield emkornfield force-pushed the stack/rename_log_schema branch from ae73945 to a37058f Compare October 22, 2025 20:47
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.78%. Comparing base (3efdae7) to head (3ec485e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/engine/arrow_data.rs 50.00% 0 Missing and 1 partial ⚠️
kernel/src/log_segment.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1419   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files         118      118           
  Lines       30286    30291    +5     
  Branches    30286    30291    +5     
=======================================
+ Hits        25678    25683    +5     
  Misses       3382     3382           
  Partials     1226     1226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emkornfield
Copy link
Collaborator Author

whoops actually looks like this schema includes the CommitMetadata action which is only allowed in V2 checkpoints. should we just remove that from this schema and ensure it's in the 'all actions' one?

Should be done.

Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

Copy link
Member

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks LGTM!

@emkornfield emkornfield merged commit e05af8c into delta-io:main Oct 22, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Change that require a major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants