-
Couldn't load subscription status.
- Fork 118
chore!: rename log_schema to commit_schema #1419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: rename log_schema to commit_schema #1419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops actually looks like this schema includes the CommitMetadata action which is only allowed in V2 checkpoints. should we just remove that from this schema and ensure it's in the 'all actions' one?
ae73945 to
a37058f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1419 +/- ##
=======================================
Coverage 84.78% 84.78%
=======================================
Files 118 118
Lines 30286 30291 +5
Branches 30286 30291 +5
=======================================
+ Hits 25678 25683 +5
Misses 3382 3382
Partials 1226 1226 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Should be done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks LGTM!
🥞 Stacked PR
Use this link to review incremental changes.
Rename schema's for more accurately describe schemas. This is follow-up from #1407