[chore] Use primitive type shortcuts in match arms #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
- Coverage 74.17% 74.15% -0.03%
==========================================
Files 43 43
Lines 8187 8180 -7
Branches 8187 8180 -7
==========================================
- Hits 6073 6066 -7
Misses 1734 1734
Partials 380 380 ☔ View full report in Codecov by Sentry. |
|
It looks like codecov is complaining because my changes happened to hit code with poor test coverage. Since there are no functional changes here (compilation suffices) I'm going ahead with merge anyway. |
nicklan
pushed a commit
to nicklan/delta-kernel-rs
that referenced
this pull request
Oct 2, 2024
We already have constants like `DataType::LONG` that can avoid boilerplate like `DataType::Primitive(PrimitiveType::Long)`, and such constants can be used in match arms. Update the code to use them.
nicklan
added a commit
to nicklan/delta-kernel-rs
that referenced
this pull request
Oct 2, 2024
)" This reverts commit 4c214c8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have constants like
DataType::LONGthat can avoid boilerplate likeDataType::Primitive(PrimitiveType::Long), and such constants can be used in match arms. Update the code to use them.