Skip to content

Conversation

@scovich
Copy link
Collaborator

@scovich scovich commented Oct 4, 2024

A perfectly good constant already existed -- use it!

@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.54%. Comparing base (092ee67) to head (9326eda).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   76.55%   76.54%   -0.02%     
==========================================
  Files          45       45              
  Lines        9375     9374       -1     
  Branches     9375     9374       -1     
==========================================
- Hits         7177     7175       -2     
- Misses       1799     1801       +2     
+ Partials      399      398       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rtyler rtyler merged commit c4be634 into delta-io:main Oct 5, 2024
11 of 12 checks passed
@scovich scovich deleted the chrono-epoch branch November 8, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants