feat: Inspect table fixes #1372
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
|
@scovich I'm curious about the variant schema stuff. Is that meant to help with the performance issues we've been seeing? |
nicklan
reviewed
Oct 15, 2025
| fn custom_log_schema() -> SchemaRef { | ||
| let fields = get_log_schema() | ||
| .fields() | ||
| .filter(|f| f.name() != "commitInfo") |
There was a problem hiding this comment.
Maybe a follow-up to actually support reading commit infos as I imagine that could be something useful to dump from a table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The
inspect-tableexample had rotted and was not runnable. It also lacked domain metadata support.Additionally, upgrade the example's
actionscommand with a--stats-onlyflag that avoids materializing file actions.The command now unconditionally emits stats such as the following:
If
--stats-onlywas not supplied, the stats are followed by a complete printout of log actions, as before.How was this change tested?
Example code now runs nicely.