refactor: avoid explicit mutex in MergeBarrier #3734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Pack <[email protected]>
roeap
force-pushed
the
refactor/merge-dashset
branch
from
2e7df3f to
7aae3d5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3734 +/- ##
=======================================
Coverage 75.36% 75.37%
=======================================
Files 145 145
Lines 43955 43946 -9
Branches 43955 43946 -9
=======================================
- Hits 33128 33123 -5
+ Misses 9222 9219 -3
+ Partials 1605 1604 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rtyler
approved these changes
Sep 3, 2025
fvaleye
pushed a commit
to fvaleye/delta-rs
that referenced
this pull request
Sep 12, 2025
# Description Just a quick drive-by refactor. We were using `Mutex<HashSet<String>>` inside the merge barrier implementation. Since we already depend on `dashmap`, we might as well use `DashSet`, which simplifies the code a little bit by avoiding explicit locks. Signed-off-by: Robert Pack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just a quick drive-by refactor. We were using
Mutex<HashSet<String>>inside the merge barrier implementation. Since we already depend ondashmap, we might as well useDashSet, which simplifies the code a little bit by avoiding explicit locks.