Skip to content

Conversation

@JustinRush80
Copy link
Contributor

@JustinRush80 JustinRush80 commented Oct 20, 2025

Description

This PR allow users to add multiple constraints at once using an HashMap.

Related Issue(s)

Documentation

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Oct 20, 2025
@github-actions
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@JustinRush80 JustinRush80 changed the title add the ability to add multiple constraints at once feat: add multiple constraints at once Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 90.38462% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.73%. Comparing base (52ada46) to head (0458633).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/operations/constraints.rs 90.96% 7 Missing and 7 partials ⚠️
python/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3879      +/-   ##
==========================================
+ Coverage   73.70%   73.73%   +0.03%     
==========================================
  Files         151      151              
  Lines       39260    39347      +87     
  Branches    39260    39347      +87     
==========================================
+ Hits        28937    29013      +76     
- Misses       9015     9023       +8     
- Partials     1308     1311       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the binding/python Issues for the Python package label Oct 21, 2025
@JustinRush80 JustinRush80 changed the title feat: add multiple constraints at once feat: add multiple constraints at once Oct 21, 2025
@JustinRush80 JustinRush80 force-pushed the feat/mulitple_constraits branch from a6bc2c7 to 252b51e Compare October 22, 2025 00:39
@JustinRush80 JustinRush80 marked this pull request as ready for review October 22, 2025 00:40
Copy link
Collaborator

@ion-elgreco ion-elgreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Just one comment for small improvement :)

}

/// Specify the constraint to be added
pub fn with_constraint<S: Into<String>, E: Into<Expression>>(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe one small nit, i think we can keep this where this just inserts in the hashmap and then we also have with_constraints which is the hashmap version. This way we don't entirely break the signature

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes that makes sense! Do we want to restrict using both with_constraint and with_constraints at the same time? At first I had with_multiple_constraints that extend the hashmap just in case someone used both builder functions

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you could have them both extend it, always

@JustinRush80 JustinRush80 force-pushed the feat/mulitple_constraits branch from 252b51e to a5a9619 Compare October 22, 2025 11:42
@ion-elgreco ion-elgreco force-pushed the feat/mulitple_constraits branch from ee317e5 to 0458633 Compare October 22, 2025 13:18
@ion-elgreco ion-elgreco enabled auto-merge (squash) October 22, 2025 13:18
@ion-elgreco ion-elgreco merged commit 1cdec0d into delta-io:main Oct 22, 2025
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/python Issues for the Python package binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add multiple constraints at once

2 participants