Skip to content

Conversation

@hntd187
Copy link
Collaborator

@hntd187 hntd187 commented Jan 14, 2026

Description

This begins the Purge of the artist formerly known as EagerSnapshot but the concept doesn't really go away as it just rolls it into Snapshot and Snapshot is meant to fulfill both purposes.

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Jan 14, 2026
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 13.55932% with 102 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.74%. Comparing base (f5ed490) to head (c6bbac3).

Files with missing lines Patch % Lines
crates/core/src/kernel/snapshot/mod.rs 20.37% 42 Missing and 1 partial ⚠️
crates/core/src/kernel/transaction/mod.rs 0.00% 10 Missing ⚠️
crates/core/src/table/state.rs 33.33% 6 Missing and 2 partials ⚠️
crates/core/src/operations/vacuum.rs 0.00% 4 Missing ⚠️
crates/test/src/read.rs 0.00% 1 Missing and 3 partials ⚠️
crates/core/src/operations/filesystem_check.rs 0.00% 3 Missing ⚠️
crates/core/src/operations/restore.rs 0.00% 3 Missing ⚠️
crates/core/src/protocol/checkpoints.rs 0.00% 3 Missing ⚠️
crates/core/src/writer/record_batch.rs 0.00% 3 Missing ⚠️
crates/core/src/kernel/transaction/protocol.rs 0.00% 2 Missing ⚠️
... and 15 more

❗ There is a different number of reports uploaded between BASE (f5ed490) and HEAD (c6bbac3). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (f5ed490) HEAD (c6bbac3)
7 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4080       +/-   ##
===========================================
- Coverage   75.96%   17.74%   -58.23%     
===========================================
  Files         164       80       -84     
  Lines       44447    11431    -33016     
  Branches    44447    11431    -33016     
===========================================
- Hits        33764     2028    -31736     
- Misses       9019     9244      +225     
+ Partials     1664      159     -1505     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hntd187
Copy link
Collaborator Author

hntd187 commented Jan 14, 2026

So @roeap I think a lot of tests are failing because the testing setup is broken from the changes, any ideas what might be the issue here? I know I'm missing like 1 place where eager snapshot was updated after a table operation but I'm not sure where.

@roeap
Copy link
Collaborator

roeap commented Jan 14, 2026

@hntd187 - i beleive before removing eager snapshot, we should make sure there are no more call sites of log_data, then remove DeltaTableProvider in favour of our new provider.
Haven't looked in the individual failures, but since its mostly (all) tests for operations, this wpould be consistent since this is the place where the old provider is still being used.

@roeap
Copy link
Collaborator

roeap commented Jan 14, 2026

also i needed to update your comment to capitalize "Purge" since this has resemblence to the Purge as we march through the codebase ad get right of too many snapshots :D.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/python Issues for the Python package binding/rust Issues for the Rust crate

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants