From 5d49234380e337b97b613d5586dcf07079d71170 Mon Sep 17 00:00:00 2001 From: Robert Pack Date: Sat, 18 Oct 2025 10:05:08 +0200 Subject: [PATCH 1/2] fix: remove some easy warnings Signed-off-by: Robert Pack --- crates/aws/tests/repair_s3_rename_test.rs | 4 ++-- crates/catalog-unity/src/datafusion.rs | 1 - crates/core/tests/read_delta_partitions_test.rs | 6 ++---- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/crates/aws/tests/repair_s3_rename_test.rs b/crates/aws/tests/repair_s3_rename_test.rs index 6f47d19b8f..d9cddb97d7 100644 --- a/crates/aws/tests/repair_s3_rename_test.rs +++ b/crates/aws/tests/repair_s3_rename_test.rs @@ -9,7 +9,7 @@ use deltalake_core::logstore::object_store::{ use deltalake_core::{DeltaTableBuilder, ObjectStore, Path}; use deltalake_test::utils::IntegrationContext; use futures::stream::BoxStream; -use object_store::{MultipartUpload, PutMultipartOpts, PutPayload}; +use object_store::{MultipartUpload, PutMultipartOptions, PutPayload}; use serial_test::serial; use std::ops::Range; use std::sync::{Arc, Mutex}; @@ -237,7 +237,7 @@ impl ObjectStore for DelayedObjectStore { async fn put_multipart_opts( &self, location: &Path, - options: PutMultipartOpts, + options: PutMultipartOptions, ) -> ObjectStoreResult> { self.inner.put_multipart_opts(location, options).await } diff --git a/crates/catalog-unity/src/datafusion.rs b/crates/catalog-unity/src/datafusion.rs index ee81efaabc..b617ed0e6b 100644 --- a/crates/catalog-unity/src/datafusion.rs +++ b/crates/catalog-unity/src/datafusion.rs @@ -6,7 +6,6 @@ use datafusion::catalog::SchemaProvider; use datafusion::catalog::{CatalogProvider, CatalogProviderList}; use datafusion::common::DataFusionError; use datafusion::datasource::TableProvider; -use futures::FutureExt; use moka::future::Cache; use moka::Expiry; use std::any::Any; diff --git a/crates/core/tests/read_delta_partitions_test.rs b/crates/core/tests/read_delta_partitions_test.rs index 7aa58a9a78..cdad7ef645 100644 --- a/crates/core/tests/read_delta_partitions_test.rs +++ b/crates/core/tests/read_delta_partitions_test.rs @@ -1,5 +1,3 @@ -use std::path::PathBuf; -use std::process::Command; use url::Url; #[allow(dead_code)] @@ -48,7 +46,7 @@ async fn read_null_partitions_from_checkpoint() { // verify that table loads from checkpoint and handles null partitions let table = deltalake_core::open_table( - url::Url::from_directory_path(std::path::Path::new(&table.table_uri())).unwrap(), + Url::from_directory_path(std::path::Path::new(&table.table_uri())).unwrap(), ) .await .unwrap(); @@ -64,7 +62,7 @@ async fn load_from_delta_8_0_table_with_special_partition() { let path = "../test/tests/data/delta-0.8.0-special-partition"; let table = deltalake_core::open_table( - url::Url::from_directory_path(std::fs::canonicalize(&path).unwrap()).unwrap(), + Url::from_directory_path(std::fs::canonicalize(&path).unwrap()).unwrap(), ) .await .unwrap(); From 207cd26fbf245739cd2016c1710bd2639a31981f Mon Sep 17 00:00:00 2001 From: Robert Pack Date: Sat, 18 Oct 2025 10:10:48 +0200 Subject: [PATCH 2/2] chore: clippy Signed-off-by: Robert Pack --- crates/core/src/delta_datafusion/table_provider.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/crates/core/src/delta_datafusion/table_provider.rs b/crates/core/src/delta_datafusion/table_provider.rs index c33474a050..3e6a4f89b0 100644 --- a/crates/core/src/delta_datafusion/table_provider.rs +++ b/crates/core/src/delta_datafusion/table_provider.rs @@ -988,10 +988,7 @@ impl ExecutionPlan for DeltaScan { parent_filters: Vec>, _config: &ConfigOptions, ) -> Result { - Ok(FilterDescription::from_children( - parent_filters, - &self.children(), - )?) + FilterDescription::from_children(parent_filters, &self.children()) } }