style: fix clippy warnings

Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>

Author: CertainLach

crates/jrsonnet-evaluator/src/builtin/mod.rs

@@ -221,7 +221,7 @@ fn builtin_slice(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc)
 		3, step: ty!((number | null));
 	], {
 		std_slice(
-			indexable.to_indexable()?,
+			indexable.into_indexable()?,
 			index.try_cast_nullable_num("index")?.map(|v| v as usize),
 			end.try_cast_nullable_num("end")?.map(|v| v as usize),
 			step.try_cast_nullable_num("step")?.map(|v| v as usize),

crates/jrsonnet-evaluator/src/evaluate/mod.rs

@@ -687,7 +687,7 @@ pub fn evaluate(context: Context, expr: &LocExpr) -> Result<Val> {
 				desc: &'static str,
 			) -> Result<Option<usize>> {
 				Ok(match expr {
-					Some(s) => evaluate(context.clone(), &s)?
+					Some(s) => evaluate(context.clone(), s)?
 						.try_cast_nullable_num(desc)?
 						.map(|v| v as usize),
 					None => None,
@@ -698,7 +698,7 @@ pub fn evaluate(context: Context, expr: &LocExpr) -> Result<Val> {
 			let end = parse_num(&context, desc.end.as_ref(), "end")?;
 			let step = parse_num(&context, desc.step.as_ref(), "step")?;
 
-			std_slice(indexable.to_indexable()?, start, end, step)?
+			std_slice(indexable.into_indexable()?, start, end, step)?
 		}
 		Import(path) => {
 			let tmp = loc

crates/jrsonnet-evaluator/src/integrations/serde.rs

@@ -47,7 +47,7 @@ impl From<&Value> for Val {
 			Value::Number(n) => Self::Num(n.as_f64().expect("as f64")),
 			Value::String(s) => Self::Str((s as &str).into()),
 			Value::Array(a) => {
-				let mut out: Vec<Val> = Vec::with_capacity(a.len());
+				let mut out: Vec<Self> = Vec::with_capacity(a.len());
 				for v in a {
 					out.push(v.into());
 				}
@@ -58,7 +58,7 @@ impl From<&Value> for Val {
 				for (k, v) in o {
 					builder.member((k as &str).into()).value(v.into());
 				}
-				Val::Obj(builder.build())
+				Self::Obj(builder.build())
 			}
 		}
 	}

crates/jrsonnet-evaluator/src/obj.rs

@@ -322,6 +322,11 @@ impl ObjValueBuilder {
 		ObjValue::new(self.super_obj, Gc::new(self.map), Gc::new(self.assertions))
 	}
 }
+impl Default for ObjValueBuilder {
+	fn default() -> Self {
+		Self::with_capacity(0)
+	}
+}
 
 #[must_use = "value not added unless binding() was called"]
 pub struct ObjMemberBuilder<'v> {
@@ -332,8 +337,9 @@ pub struct ObjMemberBuilder<'v> {
 	location: Option<ExprLocation>,
 }
 
+#[allow(clippy::missing_const_for_fn)]
 impl<'v> ObjMemberBuilder<'v> {
-	pub fn with_add(mut self, add: bool) -> Self {
+	pub const fn with_add(mut self, add: bool) -> Self {
 		self.add = add;
 		self
 	}

crates/jrsonnet-evaluator/src/val.rs

@@ -571,7 +571,7 @@ impl Val {
 			.try_cast_str("to json")
 		})
 	}
-	pub fn to_indexable(self) -> Result<IndexableVal> {
+	pub fn into_indexable(self) -> Result<IndexableVal> {
 		Ok(match self {
 			Val::Str(s) => IndexableVal::Str(s),
 			Val::Arr(arr) => IndexableVal::Arr(arr),