Merge pull request #13323 from demarche-numerique/worktree-radiant-knitting-catmull

Tech: l'authentification admin doit précéder retrieve_procedure (RAILS-K79)

Author: mmagn

app/controllers/administrateurs/types_de_champ_controller.rb

@@ -4,9 +4,11 @@ module Administrateurs
   class TypesDeChampController < AdministrateurController
     include ActiveSupport::NumberHelper
     include CsvParsingConcern
+
+    before_action :retrieve_procedure
+
     include SimpliscoreConcern
 
-    prepend_before_action :retrieve_procedure
     before_action :reload_procedure_with_includes, only: [:destroy]
 
     def create

spec/controllers/administrateurs/types_de_champ_controller_spec.rb

@@ -26,6 +26,16 @@ def morpheds
 
   before { sign_in(procedure.administrateurs.first.user) }
 
+  describe 'unauthenticated access' do
+    before { sign_out(procedure.administrateurs.first.user) }
+
+    it 'redirects to sign in instead of raising' do
+      get :new_simplify, params: { procedure_id: procedure.id }
+
+      expect(response).to redirect_to(new_user_session_path)
+    end
+  end
+
   describe '#create' do
     let(:params) { default_params }