feat(siret_champ): block submission when the siret champ feeds a condition

A condition can target a column of a SIRET champ (value_json), so it
cannot be evaluated until the data is fetched. In that case the
historical blocking validation is restored via dependent_conditions?.

Author: E-L-T

app/models/champs/siret_champ.rb

@@ -13,6 +13,12 @@ def lenient_external_data_validation?
     true
   end
 
+  # A condition based on one of this champ's columns (value_json) cannot be
+  # evaluated until the data is fetched: restore the blocking validation.
+  def external_data_required_for_conditions?
+    dependent_conditions?
+  end
+
   def external_data_status_message
     return :technical_error if etablissement&.as_degraded_mode?
 

spec/models/champs/siret_champ_spec.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 describe Champs::SiretChamp do
+  include Logic
+
   let(:procedure) { create(:procedure, types_de_champ_public: [{ type: :siret }]) }
   let(:dossier) { create(:dossier, procedure:) }
   let(:champ) { dossier.champs.first.tap { _1.update(external_id:, etablissement:) } }
@@ -273,6 +275,26 @@
     end
   end
 
+  describe '#external_data_required_for_conditions?' do
+    let(:procedure) { create(:procedure, types_de_champ_public: [{ type: :siret }, { type: :text }]) }
+    let(:siret_tdc) { procedure.draft_revision.types_de_champ_public.first }
+    let(:text_tdc) { procedure.draft_revision.types_de_champ_public.second }
+    let(:champ) { dossier.champs.find(&:siret?) }
+
+    context 'when no other champ has a condition based on the siret champ' do
+      it { expect(champ.external_data_required_for_conditions?).to be false }
+    end
+
+    context 'when another champ has a condition based on a column of the siret champ' do
+      before do
+        naf_column = siret_tdc.columns(procedure_id: procedure.id).find { _1.label.match?(/NAF/i) }
+        text_tdc.update!(condition: ds_eq(champ_column_value(naf_column), constant('4950Z')))
+      end
+
+      it { expect(champ.external_data_required_for_conditions?).to be true }
+    end
+  end
+
   describe '#reset_external_data!' do
     let(:external_id) { "12345678901245" }
     let(:etablissement) { create(:etablissement, siret: external_id) }

spec/models/concerns/champ_external_data_concern_spec.rb

@@ -99,7 +99,7 @@
     let(:champ) { Champs::SiretChamp.new }
 
     it 'returns nil when fetched' do
-      allow(champ).to receive_messages(pending?: false, external_error?: false)
+      allow(champ).to receive_messages(pending?: false, external_error?: false, external_data_required_for_conditions?: false)
       expect(champ.external_data_status_message).to be_nil
     end
 

spec/validators/external_data_champ_validator_spec.rb

@@ -21,7 +21,7 @@
   end
 
   context 'fetched' do
-    before { allow(champ).to receive_messages(pending?: false, external_error?: false) }
+    before { allow(champ).to receive_messages(pending?: false, external_error?: false, external_data_required_for_conditions?: false) }
     include_examples 'no error added'
   end