feat(identity): support anonymous procedures in usager dossier flow

Author: tchak

app/controllers/users/commencer_controller.rb

@@ -128,7 +128,8 @@ def build_prefilled_dossier
       @prefilled_dossier = Dossier.new(
         revision: @revision,
         state: Dossier.states.fetch(:brouillon),
-        prefilled: true
+        prefilled: true,
+        autorisation_donnees: @procedure.for_anonymous?
       )
       @prefilled_dossier.build_default_values
       if @prefilled_dossier.save

app/controllers/users/dossiers_controller.rb

@@ -438,17 +438,20 @@ def new
       dossier = Dossier.new(
         revision: params[:brouillon] ? procedure.draft_revision : procedure.active_revision,
         user: current_user,
-        state: Dossier.states.fetch(:brouillon)
+        state: Dossier.states.fetch(:brouillon),
+        autorisation_donnees: procedure.for_anonymous?
       )
       dossier.build_default_values
       dossier.save!
       DossierMailer.with(dossier:).notify_new_draft.deliver_later(wait: 1.hour)
       Ami::CreateNotificationService.call(dossier:)
 
-      if dossier.procedure.for_individual
+      if dossier.procedure.for_individual?
         redirect_to identite_dossier_path(dossier)
-      else
+      elsif dossier.procedure.for_personne_morale?
         redirect_to siret_dossier_path(id: dossier.id)
+      else
+        redirect_to dossier_path(dossier)
       end
     end
 
@@ -550,7 +553,7 @@ def ensure_dossier_can_be_updated
 
     def ensure_dossier_can_be_filled
       if !dossier.autorisation_donnees
-        if dossier.procedure.for_individual
+        if dossier.procedure.for_individual?
           flash.alert = t('users.dossiers.fill_identity.individual')
           redirect_to identite_dossier_path(dossier)
         else

app/views/users/dossiers/_identity_dropdown.html.haml

@@ -8,7 +8,7 @@
 
     #identity.fr-collapse.fr-menu
       .fr-menu__list.dossier-show.edit-identity-content
-        - if dossier.procedure.for_individual
+        - if dossier.procedure.for_individual?
           %dl.fr-pl-0
             = render partial: "shared/dossiers/identite_individual", locals: { dossier: dossier }
 

spec/controllers/instructeurs/dossiers_controller_spec.rb

@@ -683,7 +683,7 @@
     end
 
     context 'when related etablissement is still in degraded_mode' do
-      let(:procedure) { create(:procedure, :published, for_individual: false, instructeurs: instructeurs) }
+      let(:procedure) { create(:procedure, :published, :for_personne_morale, instructeurs: instructeurs) }
       let(:dossier) { create(:dossier, :en_instruction, :with_entreprise, procedure: procedure, as_degraded_mode: true) }
 
       subject { post :terminer, params: { process_action: "accepter", procedure_id: procedure.id, dossier_id: dossier.id, statut: 'a-suivre' }, format: :turbo_stream }

spec/controllers/users/commencer_controller_spec.rb

@@ -247,6 +247,16 @@
           it_behaves_like 'a prefilled brouillon dossier creator'
         end
 
+        context 'when the procedure is anonymous' do
+          let(:published_procedure) { create(:procedure, :for_anonymous, :published, types_de_champ_public:, robots_indexable:) }
+          subject { get :commencer, params: { path: path, "champ_#{type_de_champ_text.to_typed_id}" => "blabla" } }
+
+          it 'authorizes data sharing on the prefilled dossier so it can be filled without an identity step' do
+            subject
+            expect(Dossier.last.autorisation_donnees).to be(true)
+          end
+        end
+
         context 'when the user is authenticated' do
           before { sign_in user }
 
@@ -526,7 +536,7 @@
     before { allow(ProConnectService).to receive(:enabled?).and_return(true) }
 
     context 'when procedure is moral and flag is enabled' do
-      let(:procedure) { create(:procedure, :published, for_individual: false) }
+      let(:procedure) { create(:procedure, :published, :for_personne_morale) }
 
       it 'shows both FranceConnect and ProConnect' do
         subject
@@ -537,7 +547,7 @@
     end
 
     context 'when procedure is moral but flag is disabled (legacy procedure)' do
-      let(:procedure) { create(:procedure, :published, for_individual: false) }
+      let(:procedure) { create(:procedure, :published, :for_personne_morale) }
 
       before { procedure.update_column(:pro_connect_for_moral_procedure, false) }
 

spec/controllers/users/dossiers_controller_spec.rb

@@ -595,7 +595,7 @@
       end
 
       context 'when the dossier is for an personne physique' do
-        before { dossier.procedure.update(for_individual: true) }
+        before { dossier.procedure.update(identity_kind: 'individual') }
 
         it { is_expected.to redirect_to(identite_dossier_path(dossier)) }
       end
@@ -2416,6 +2416,17 @@
             it { is_expected.to redirect_to identite_dossier_path(id: Dossier.last) }
           end
 
+          context 'when procedure is anonymous' do
+            let(:procedure) { create(:procedure, :published, :for_anonymous) }
+
+            it { is_expected.to redirect_to dossier_path(id: Dossier.last) }
+
+            it 'authorizes data sharing without an identity step' do
+              subject
+              expect(Dossier.last.autorisation_donnees).to be(true)
+            end
+          end
+
           it 'enqueues AMI notification for created draft' do
             subject
 

spec/helpers/dossier_helper_spec.rb

@@ -61,7 +61,7 @@
     end
 
     context "when the dossier is for a company" do
-      let(:procedure) { create(:procedure, for_individual: false) }
+      let(:procedure) { create(:procedure, :for_personne_morale) }
 
       context "when the company is not provided" do
         let(:etablissement) { nil }

spec/system/users/dossier_creation_spec.rb

@@ -224,6 +224,28 @@
         expect(page).to have_field('Numéro SIRET', with: '0000')
       end
     end
+
+    context 'when the procedure is anonymous' do
+      let(:procedure) { create(:procedure, :published, :for_anonymous, :with_service, types_de_champ_public: [{ type: :text, libelle: 'Votre demande' }]) }
+      let(:dossier) { procedure.dossiers.last }
+
+      scenario 'the user reaches the form directly and deposes a dossier without identifying' do
+        visit commencer_path(path: procedure.path)
+        click_on 'Commencer la démarche'
+
+        # no identity nor SIRET step: straight to the form
+        expect(page).to have_current_path(brouillon_dossier_path(dossier))
+        expect(dossier.autorisation_donnees).to be(true)
+
+        fill_in('Votre demande', with: 'super demande')
+        click_on 'Déposer le dossier'
+        click_on 'Accéder au dossier'
+
+        dossier.reload
+        expect(dossier.state).to eq('en_construction')
+        expect(dossier.project_champ(procedure.published_revision.types_de_champ_public.first).value).to eq('super demande')
+      end
+    end
   end
 
   context 'when the user is not signed in' do

spec/views/instructeur/dossiers/show.html.haml_spec.rb

@@ -175,7 +175,7 @@
   context 'when the dossier was submitted with FranceConnect' do
     let(:france_connect_information) { build(:france_connect_information) }
     let(:user) { build(:user, france_connect_informations: [france_connect_information]) }
-    let(:procedure1) { create(:procedure, :with_type_de_champ, for_individual: true) }
+    let(:procedure1) { create(:procedure, :with_type_de_champ) }
     let(:dossier) { create(:dossier, procedure: procedure1, user: user, submitted_with_france_connect: true) }
 
     before do

spec/views/shared/dossiers/_header.html.haml.spec.rb

@@ -57,7 +57,7 @@
 
   describe "identity edit" do
     context "when the identity is individual" do
-      let(:procedure) { create(:procedure, for_individual: true) }
+      let(:procedure) { create(:procedure, :for_individual) }
       let(:dossier) { create(:dossier, :with_individual, state: "brouillon", procedure: procedure) }
 
       it "display identity with an edit link" do
@@ -67,7 +67,7 @@
     end
 
     context "when the identity is an enterprise" do
-      let(:procedure) { create(:procedure, for_individual: false) }
+      let(:procedure) { create(:procedure, :for_personne_morale) }
       let(:dossier) { create(:dossier, :with_entreprise, state: "brouillon", procedure: procedure) }
 
       it "display short identity with an edit siret link" do