refactor(mails): drop the write-only rich_body machinery

The Trix form was the only reader of the ActionText rich_body; with the
tiptap editor in place, the copy-on-save callback and the attribute
only produced dead writes. Existing action_text_rich_texts rows can be
cleaned up later with a maintenance task.

Author: colinux

app/models/concerns/mail_template_concern.rb

@@ -35,10 +35,6 @@ def attachment_for_dossier(dossier)
     nil
   end
 
-  def update_rich_body
-    self.rich_body = self.body
-  end
-
   def tiptap_body
     json_body&.to_json
   end
@@ -77,9 +73,6 @@ def tiptap_subject_or_default
   end
 
   included do
-    has_rich_text :rich_body
-    before_save :update_rich_body
-
     validates :json_body, tags: true, if: -> { json_body.present? }
     validates :json_subject, tags: true, if: -> { json_subject.present? }
     validates :body, tags: true, if: -> { json_body.blank? }
@@ -89,9 +82,9 @@ def tiptap_subject_or_default
   class_methods do
     def default_for_procedure(procedure)
       template_name = default_template_name_for_procedure(procedure)
-      rich_body = ActionController::Base.render(template: template_name).gsub(/<!--.*?-->/m, '')
-      trix_rich_body = rich_body.gsub(/(?<!^|[.-])(?<!<\/strong>)\n/, ' ')
-      new(subject: const_get(:DEFAULT_SUBJECT), body: trix_rich_body, rich_body: trix_rich_body, procedure: procedure)
+      body = ActionController::Base.render(template: template_name).gsub(/<!--.*?-->/m, '')
+      body = body.gsub(/(?<!^|[.-])(?<!<\/strong>)\n/, ' ')
+      new(subject: const_get(:DEFAULT_SUBJECT), body:, procedure:)
     end
 
     def default_template_name_for_procedure(procedure)

spec/models/concerns/mail_template_concern_spec.rb

@@ -171,12 +171,6 @@
     end
   end
 
-  describe '#update_rich_body' do
-    before { initiated_mail.update(body: "Voici le corps du mail") }
-
-    it { expect(initiated_mail.rich_body.to_plain_text).to eq(initiated_mail.body) }
-  end
-
   describe '#tiptap_inline_nodes_for' do
     it 'résout --numéro du dossier-- en mention' do
       nodes = mail.tiptap_inline_nodes_for('Dossier --numéro du dossier--')

spec/models/procedure_spec.rb

@@ -120,7 +120,7 @@
     let(:procedure) { create(:procedure, attestation_acceptation_template: attestation_template) }
     let(:attestation_template) { nil }
 
-    subject { procedure.accepter_email_template.rich_body.body.to_html }
+    subject { procedure.accepter_email_template.body }
 
     context 'for procedures without an attestation' do
       it { is_expected.not_to include('lien attestation') }
@@ -147,7 +147,7 @@
     let(:procedure) { create(:procedure, attestation_refus_template: attestation_template) }
     let(:attestation_template) { nil }
 
-    subject { procedure.refuser_email_template.rich_body.body.to_html }
+    subject { procedure.refuser_email_template.body }
 
     context 'for procedures without an attestation' do
       it { is_expected.not_to include('lien attestation') }