refactor(jdma): Drop the now-unused Procedure#monavis_embed_html_source

Both callers are gone: the merci page and the email block now go through
MonAvisEmbed, which extracts the link instead of reinjecting the admin's
markup.

The brakeman entry that silenced the XSS warning on this method goes
with it. Left behind it would keep ignoring a fingerprint nothing
produces, and would mask a future unescaped attribute in _merci.

Author: colinux

app/models/procedure.rb

@@ -788,10 +788,6 @@ def reset_closing_params
     update!(closing_reason: nil, closing_details: nil, replaced_by_procedure_id: nil, closing_notification_brouillon: false, closing_notification_en_cours: false)
   end
 
-  def monavis_embed_html_source(source)
-    monavis_embed.gsub('nd_source=button', "nd_source=#{source}").gsub('<a ', '<a target="_blank" rel="noopener noreferrer" ')
-  end
-
   def mail_templates
     [
       self.passer_en_construction_email_template,

config/brakeman.ignore

@@ -88,50 +88,6 @@
       ],
       "note": ""
     },
-    {
-      "warning_type": "Cross-Site Scripting",
-      "warning_code": 2,
-      "fingerprint": "7f0acb2033d71136d7c2bc75ad3b5d4cf1abb3363a60e447a1b40df6c9e47854",
-      "check_name": "CrossSiteScripting",
-      "message": "Unescaped model attribute",
-      "file": "app/views/users/dossiers/_merci.html.erb",
-      "line": 77,
-      "link": "https://brakemanscanner.org/docs/warning_types/cross_site_scripting",
-      "code": "current_user.dossiers.includes(:procedure).find(params[:id]).procedure.monavis_embed_html_source(\"site\")",
-      "render_path": [
-        {
-          "type": "controller",
-          "class": "Users::DossiersController",
-          "method": "merci",
-          "line": 375,
-          "file": "app/controllers/users/dossiers_controller.rb",
-          "rendered": {
-            "name": "users/dossiers/merci",
-            "file": "app/views/users/dossiers/merci.html.haml"
-          }
-        },
-        {
-          "type": "template",
-          "name": "users/dossiers/merci",
-          "line": 6,
-          "file": "app/views/users/dossiers/merci.html.haml",
-          "rendered": {
-            "name": "users/dossiers/_merci",
-            "file": "app/views/users/dossiers/_merci.html.erb"
-          }
-        }
-      ],
-      "location": {
-        "type": "template",
-        "template": "users/dossiers/_merci"
-      },
-      "user_input": "current_user.dossiers.includes(:procedure)",
-      "confidence": "Weak",
-      "cwe_id": [
-        79
-      ],
-      "note": ""
-    },
     {
       "warning_type": "Remote Code Execution",
       "warning_code": 25,