Merge pull request #12899 from demarche-numerique/admin-can-personnalize-dossiers-table-migration-ldu

[PART:1] ETQ administrateur, je peux personnaliser le tableau de suivi des dossiers et l’appliquer en vue par défaut pour tous les instructeurs

Author: colinux

app/controllers/instructeurs/procedure_presentation_controller.rb

@@ -96,10 +96,14 @@ def procedure_presentation_params
         h[filter_name] = h.delete("filters") # move filters to the right key, ex: tous_filters
       end
 
-      # React ComboBox/MultiComboBox return [''] when no value is selected
-      # We need to remove them
       if h[:displayed_columns].present?
+        # React ComboBox/MultiComboBox return [''] when no value is selected
+        # We need to remove them
         h[:displayed_columns] = h[:displayed_columns].reject(&:empty?)
+
+        # when instructeur update displayed_columns, `customized` becomes true
+        # we consider he knows how to use the personnalization
+        h[:customized] = true
       end
 
       h

app/tasks/maintenance/t20260303_backfill_customized_on_procedure_presentations_task.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module Maintenance
+  class T20260303BackfillCustomizedOnProcedurePresentationsTask < MaintenanceTasks::Task
+    include RunnableOnDeployConcern
+
+    def collection
+      ProcedurePresentation.includes(assign_to: :procedure)
+    end
+
+    def process(presentation)
+      procedure = presentation.assign_to.procedure
+
+      presentation.update_columns(
+        customized: presentation.displayed_columns.map(&:h_id).sort != procedure.default_displayed_columns.map(&:h_id).sort
+      )
+
+    # a column can be not found for various reasons (deleted tdc, changed type, etc)
+    # in this case we just ignore the error and continue
+    rescue ActiveRecord::RecordNotFound
+    end
+  end
+end

db/migrate/20260303172300_add_customized_to_procedure_presentations.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class AddCustomizedToProcedurePresentations < ActiveRecord::Migration[7.2]
+  def change
+    add_column :procedure_presentations, :customized, :boolean, default: false, null: false
+  end
+end

db/schema.rb

@@ -1001,6 +1001,7 @@
     t.jsonb "archives_filters", default: [], null: false, array: true
     t.integer "assign_to_id"
     t.datetime "created_at", precision: nil
+    t.boolean "customized", default: false, null: false
     t.jsonb "displayed_columns", default: [], null: false, array: true
     t.jsonb "displayed_fields", default: [{"label"=>"Demandeur", "table"=>"user", "column"=>"email"}], null: false
     t.jsonb "expirant_filters", default: [], null: false, array: true

spec/controllers/instructeurs/procedure_presentation_controller_spec.rb

@@ -47,6 +47,7 @@
 
         filtered_column = FilteredColumn.new(column: state_column, filter: 'en_construction')
         expect(procedure_presentation.tous_filters).to eq([filtered_column])
+        expect(procedure_presentation.customized).to eq(true)
       end
     end
 
@@ -108,6 +109,7 @@
         expect(response.body).to include('<turbo-stream action="refresh">')
 
         expect(procedure_presentation.reload.tous_filters).to eq([FilteredColumn.new(column:, filter: { operator: 'in', value: ['Marseille'] })])
+        expect(procedure_presentation.reload.customized).to eq(false)
       end
     end
 

spec/tasks/maintenance/t20260303_backfill_customized_on_procedure_presentations_task.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+module Maintenance
+  RSpec.describe T20260303BackfillCustomizedOnProcedurePresentationsTask do
+    describe "#process" do
+      let(:procedure) { create(:procedure, :published) }
+      let(:instructeur) { create(:instructeur) }
+
+      let!(:assign_to_default) { create(:assign_to, procedure: procedure, instructeur: instructeur) }
+
+      let!(:assign_to_custom) { create(:assign_to, procedure: procedure, instructeur: create(:instructeur)) }
+
+      let!(:presentation_default) do
+        create(
+          :procedure_presentation,
+          assign_to: assign_to_default,
+          displayed_columns: procedure.default_displayed_columns
+        )
+      end
+
+      let!(:custom_column) { procedure.find_column(label: "Date de dépôt") }
+
+      let!(:presentation_custom) do
+        pres = create(:procedure_presentation, assign_to: assign_to_custom)
+        pres.update!(displayed_columns: [custom_column])
+        pres
+      end
+
+      it "marks presentations with default columns as customized: false" do
+        task = described_class.new
+        task.collection.each { |p| task.process(p) }
+        expect(presentation_default.reload.customized).to eq(false)
+      end
+
+      it "marks presentations with custom columns as customized: true" do
+        task = described_class.new
+        task.collection.each { |p| task.process(p) }
+        expect(presentation_custom.reload.customized).to eq(true)
+      end
+    end
+  end
+end