fix(siret): stop showing a redundant warning message on technical_error

For a SIRET champ, the non-blocking technical_error banner (added below
the input) and this component's own external_error warning were both
rendered at once, contradicting each other visually (blue info + red
warning for the same non-blocking state). The warning branch is
unreachable for :not_found (validation errors take precedence in the
template) and now redundant for :technical_error, so it's removed along
with its now-unused translations.

Author: E-L-T

app/components/dsfr/input_status_message_component.rb

@@ -60,8 +60,6 @@ def statut_message
           { state: :info, text: t('.siret.fetched_with_capital', raison_sociale_or_name: displayable_raison_sociale_or_name(@champ.etablissement), forme_juridique: @champ.etablissement.entreprise_forme_juridique, capital_sociale: pretty_currency(@champ.etablissement.entreprise_capital_social)) }
         elsif @champ.etablissement && @champ.etablissement.entreprise_capital_social.blank?
           { state: :info, text: t('.siret.fetched', raison_sociale_or_name: displayable_raison_sociale_or_name(@champ.etablissement), forme_juridique: @champ.etablissement.entreprise_forme_juridique) }
-        elsif @champ.external_error?
-          { state: :warning, text: t('.siret.error', value: pretty_siret(@champ.external_id)) }
         elsif @champ.pending?
           { state: :info, text: t('.siret.pending', value: pretty_siret(@champ.external_id)) }
         end

app/components/dsfr/input_status_message_component/input_status_message_component.en.yml

@@ -8,7 +8,6 @@ en:
     pending: "Search in progress for SIRET %{value}…"
     fetched_with_capital: "%{raison_sociale_or_name} %{forme_juridique} with a share capital of %{capital_sociale}"
     fetched: "%{raison_sociale_or_name} %{forme_juridique}"
-    error: "An error occurred while retrieving SIRET information."
   referentiel:
     not_configured: "This field has not been configured by the administrator yet."
     fetching: "Search in progress."

app/components/dsfr/input_status_message_component/input_status_message_component.fr.yml

@@ -8,7 +8,6 @@ fr:
     pending: "Recherche en cours pour le SIRET %{value}…"
     fetched_with_capital: "%{raison_sociale_or_name} %{forme_juridique} au capital social de %{capital_sociale}"
     fetched: "%{raison_sociale_or_name} %{forme_juridique}"
-    error: "Une erreur est survenue lors de la récupération des informations SIRET."
   referentiel:
     not_configured: "Ce champ n’est pas encore configuré par l’administrateur."
     fetching: "Recherche en cours."

spec/components/input_status_message_component_spec.rb

@@ -240,6 +240,21 @@
         end
       end
 
+      context "when external fetch failed with a technical error (non-blocking)" do
+        before do
+          champ.update!(etablissement: nil)
+          champ.update_columns(
+            external_id: '80879023200025',
+            external_state: 'external_error',
+            fetch_external_data_exceptions: [ExternalDataException.new(error: 'API down', code: 503, kind: :technical_error)]
+          )
+        end
+
+        it "does not render a warning message (the non-blocking info banner already covers it)" do
+          expect(subject).not_to have_css(".fr-message--warning")
+        end
+      end
+
       context "when etablissement is non-diffusible (diffusable_commercialement: false)" do
         before do
           etablissement = create(:etablissement, :non_diffusable, entreprise_raison_sociale: "SECRET EI", entreprise_forme_juridique: "Entrepreneur individuel")