fix(ocr_service): always include code: in failures

OCRService was the only fetch_external_data producer returning a
Failure without a code key. Fix it at the source and remove the
code-less pattern-match arm from ChampExternalDataConcern.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: E-L-T

app/models/concerns/champ_external_data_concern.rb

@@ -110,10 +110,6 @@ def handle_result(result)
         save_external_error(error, code)
         Sentry.capture_exception(error) if code != 404
         external_data_error!
-      in Failure(retryable: false, error:)
-        save_external_error(error, nil)
-        Sentry.capture_exception(error)
-        external_data_error!
       end
     elsif result.present?
       update_external_data!(data: result)

app/services/ocr_service.rb

@@ -144,16 +144,17 @@ def self.fetch_ban_address(query)
   def self.ocr_url = ENV.fetch("OCR_SERVICE_URL", nil)
   def self.document_ia_url = ENV.fetch("DOCUMENT_IA_URL", nil)
 
+  # code: is always present: ChampExternalDataConcern#handle_result pattern-matches on it
   def self.not_configured(message)
-    Failure(retryable: false, error: StandardError.new("#{message} not configured"))
+    Failure(retryable: false, error: StandardError.new("#{message} not configured"), code: nil)
   end
 
   def self.to_not_retryable_failure(data)
     case data
     in code:, error:
       Failure(retryable: false, error:, code:)
     else
-      Failure(retryable: false, error: StandardError.new('Unknown error'))
+      Failure(retryable: false, error: StandardError.new('Unknown error'), code: nil)
     end
   end
 end

spec/models/concerns/champ_external_data_concern_spec.rb

@@ -48,12 +48,12 @@
       end
     end
 
-    context 'with a Failure without code (legacy service — API::Client::Error or un-migrated service)' do
+    context 'with a non-retryable Failure carrying a nil code (service without HTTP code)' do
       it 'persists a nil code exception and moves to external_error' do
         allow(champ).to receive(:ready_for_external_call?).and_return(true)
         champ.fetch_later!
 
-        result = Failure(retryable: false, error: StandardError.new('not configured'))
+        result = Failure(retryable: false, error: StandardError.new('not configured'), code: nil)
         allow(champ).to receive(:fetch_external_data).and_return(result)
         champ.fetch!
 

spec/services/ocr_service_spec.rb

@@ -54,6 +54,22 @@
         end
       end
     end
+
+    context 'when the service is not configured' do
+      let(:blob) { double('Blob', url: 'http://example.com/blob.pdf') }
+
+      before do
+        allow(ENV).to receive(:fetch).and_call_original
+        allow(ENV).to receive(:fetch).with("OCR_SERVICE_URL", nil).and_return(nil)
+      end
+
+      # ChampExternalDataConcern#handle_result pattern-matches on the code: key
+      it 'returns a failure carrying a code key' do
+        analysis = described_class.analyze(blob, nature: 'rib')
+        expect(analysis.failure?).to be true
+        expect(analysis.failure).to include(retryable: false, code: nil)
+      end
+    end
   end
 
   describe '#analyze with unknown nature' do
@@ -65,6 +81,13 @@
     end
   end
 
+  describe '#to_not_retryable_failure with an unrecognized failure shape' do
+    it 'returns a failure carrying a code key' do
+      failure = described_class.to_not_retryable_failure(:boom)
+      expect(failure.failure).to include(retryable: false, code: nil)
+    end
+  end
+
   describe '#analyze_2ddoc' do
     let(:document_ia_url) { 'https://some_url.fr' }
     let(:document_ia_key) { 'some_key' }