feat(usager): show non-blocking info message when external data is pending or in technical error

Author: E-L-T

app/components/editable_champ/siret_component/siret_component.html.haml

@@ -1 +1,4 @@
 = @form.text_field(:external_id, input_opts(value: pretty_siret(@champ.external_id), id: @champ.focusable_input_id, aria: { **labelledby_id_attr, describedby: "#{@champ.describedby_id} #{@champ.error_id(:value)}" }, data: { controller: 'format', format: 'siret',  }, required: @champ.required?, class: "width-33-desktop"))
+
+- if @champ.external_data_status_message.present?
+  %p.fr-info-text{ role: 'status' }= t("shared.champs.external_data.#{@champ.external_data_status_message}")

app/models/concerns/champ_external_data_concern.rb

@@ -67,6 +67,18 @@ module ChampExternalDataConcern
   def pending? = waiting_for_job? || fetching?
   def done? = fetched? || external_error?
 
+  # Non-blocking status surfaced to the usager while they can still submit.
+  # Returns :pending or :technical_error, or nil when there is nothing to show:
+  # fetched, an explicit :not_found (handled by a blocking validation error),
+  # or when the data is required for a logic condition (legacy blocking).
+  def external_data_status_message
+    return nil if external_data_required_for_conditions?
+    return :pending if pending?
+    return :technical_error if external_error? && fetch_external_data_exceptions&.first&.kind != :not_found
+
+    nil
+  end
+
   def has_async_external_data? = false
 
   def external_data_needed_for_validation? = has_async_external_data?

config/i18n-tasks.yml

@@ -99,6 +99,7 @@ search:
 ## Consider these keys used:
 ignore_unused:
   - 'errors.format'
+  - 'shared.champs.external_data.*' # dynamic key: t("shared.champs.external_data.#{external_data_status_message}")
   - 'user_mailer.*.subject'
   - 'activerecord.models.*'
   - 'activerecord.attributes.*'

config/locales/shared.en.yml

@@ -23,6 +23,9 @@ en:
       move_down: Move down
 
     champs:
+      external_data:
+        pending: "Automatic verification of the number is in progress. You can continue submitting; the information will be retrieved as soon as possible."
+        technical_error: "Automatic verification is temporarily unavailable. You can continue submitting; the information will be retrieved as soon as possible."
       drop_down_list:
         other: Enter another option
         other_label: Enter your option

config/locales/shared.fr.yml

@@ -25,6 +25,9 @@ fr:
       move_down: Déplacer vers le bas
 
     champs:
+      external_data:
+        pending: "La vérification automatique du numéro est en cours. Vous pouvez poursuivre le dépôt ; les informations seront récupérées dès que possible."
+        technical_error: "La vérification automatique est temporairement indisponible. Vous pouvez poursuivre le dépôt ; les informations seront récupérées dès que possible."
       rna:
         show:
           not_filled: non renseigné

spec/models/concerns/champ_external_data_concern_spec.rb

@@ -79,6 +79,43 @@
     end
   end
 
+  describe '#external_data_status_message' do
+    let(:champ) { Champs::SiretChamp.new }
+
+    it 'returns nil when fetched' do
+      allow(champ).to receive_messages(pending?: false, external_error?: false)
+      expect(champ.external_data_status_message).to be_nil
+    end
+
+    it 'returns :pending when pending and not required for conditions' do
+      allow(champ).to receive_messages(pending?: true, external_error?: false, external_data_required_for_conditions?: false)
+      expect(champ.external_data_status_message).to eq(:pending)
+    end
+
+    it 'returns :technical_error on external_error with non-not_found kind' do
+      allow(champ).to receive_messages(
+        pending?: false, external_error?: true,
+        external_data_required_for_conditions?: false,
+        fetch_external_data_exceptions: [ExternalDataException.new(error: 'x', code: 503, kind: :technical_error)]
+      )
+      expect(champ.external_data_status_message).to eq(:technical_error)
+    end
+
+    it 'returns nil on :not_found (handled by the validation error)' do
+      allow(champ).to receive_messages(
+        pending?: false, external_error?: true,
+        external_data_required_for_conditions?: false,
+        fetch_external_data_exceptions: [ExternalDataException.new(error: 'x', code: 404, kind: :not_found)]
+      )
+      expect(champ.external_data_status_message).to be_nil
+    end
+
+    it 'returns nil when external_data_required_for_conditions? is true' do
+      allow(champ).to receive_messages(pending?: true, external_error?: false, external_data_required_for_conditions?: true)
+      expect(champ.external_data_status_message).to be_nil
+    end
+  end
+
   describe 'the state machine' do
     let(:procedure) { create(:procedure, types_de_champ_public: [{ type: :rnf }]) }
     let(:dossier) { create(:dossier, procedure:) }