fix(siret_type_de_champ): mandatory check no longer requires a resolved etablissement

champ_blank_or_invalid? checked Siret.new(siret: champ.value), but
value is only populated by a successful fetch (update_external_data!).
For a mandatory SIRET champ, this meant the dossier's mandatory-field
check (Dossier#check_mandatory_and_visible_champs_for) always blocked
submission while pending or in a non-blocking technical_error,
regardless of ExternalDataChampValidator's kind-aware logic.

Check external_id's format instead: it's set as soon as the user types
a SIRET and survives resets, so a mandatory field is satisfied by a
syntactically valid input. Whether that SIRET actually exists is
ExternalDataChampValidator's separate, kind-aware concern.

Author: E-L-T

app/models/types_de_champ/siret_type_de_champ.rb

@@ -7,7 +7,10 @@ def estimated_fill_duration(revision)
     FILL_DURATION_MEDIUM
   end
 
-  def champ_blank_or_invalid?(champ) = Siret.new(siret: champ.value).invalid?
+  # A syntactically valid external_id is enough to satisfy the mandatory
+  # check while the async fetch is pending or failed non-blockingly:
+  # the actual blocking decision belongs to ExternalDataChampValidator.
+  def champ_blank_or_invalid?(champ) = Siret.new(siret: champ.external_id).invalid?
 
   def columns(procedure_id:, displayable: true, prefix: nil)
     super

spec/models/champs/siret_champ_spec.rb

@@ -85,6 +85,42 @@
     end
   end
 
+  describe '#mandatory_blank?' do
+    let(:procedure) { create(:procedure, types_de_champ_public: [{ type: :siret, mandatory: true }]) }
+    let(:external_id) { "12345678901245" }
+
+    context 'when the fetch is pending' do
+      before { champ.update_columns(external_state: 'waiting_for_job') }
+
+      it 'is not mandatory_blank (a syntactically valid SIRET is enough while pending)' do
+        expect(champ.mandatory_blank?).to be false
+      end
+    end
+
+    context 'when the fetch failed with a technical error' do
+      let(:exception) { ExternalDataException.new(error: 'API down', code: 503, kind: :technical_error) }
+
+      before do
+        champ.update_columns(
+          external_state: 'external_error',
+          fetch_external_data_exceptions: [exception]
+        )
+      end
+
+      it 'is not mandatory_blank (a syntactically valid SIRET is enough despite the technical error)' do
+        expect(champ.mandatory_blank?).to be false
+      end
+    end
+
+    context 'when the format is invalid' do
+      let(:external_id) { "12345" }
+
+      it 'is mandatory_blank' do
+        expect(champ.mandatory_blank?).to be true
+      end
+    end
+  end
+
   describe '.fetch_external_data' do
     let(:api_etablissement_status) { 200 }
     let(:api_etablissement_body) { File.read('spec/fixtures/files/api_entreprise/etablissements.json') }

spec/models/dossier_spec.rb

@@ -2062,7 +2062,7 @@
       let(:champ_siret) { dossier.champs.first }
 
       before do
-        champ_siret.update(value: '44011762001530')
+        champ_siret.update(external_id: '44011762001530', value: '44011762001530', etablissement: build(:etablissement, siret: '44011762001530'))
       end
 
       it 'should not have errors' do
@@ -2071,7 +2071,7 @@
 
       context "and invalid SIRET" do
         before do
-          champ_siret.update(value: "1234")
+          champ_siret.update(external_id: "1234", value: "1234")
           dossier.reload
         end