test: hoist per-example procedure creation in dossier spec

Use let_it_be for custom procedures (sva/svr, declarative, prefill,
attestation champs) and before_all for fleet setups (unread messages,
archivable_by_month), and reuse seeded procedures where the factory
default sufficed. Full spec: ~38.5s -> ~33s (-38% vs factory baseline).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: tchak

spec/models/dossier_spec.rb

@@ -103,36 +103,41 @@
         travel_to(5.months.ago) do
           create(:dossier,
             state: :brouillon,
+            procedure: procedures.demo,
             brouillon_close_to_expiration_notice_sent_at: 1.day.ago)
         end
       end
 
       let!(:dossier_brouillon_not_expired) do
         travel_to(1.month.ago) do
           create(:dossier,
-            state: :brouillon)
+            state: :brouillon,
+            procedure: procedures.demo)
         end
       end
 
       let!(:dossier_brouillon_expired_but_noticed_recently) do
         travel_to(5.months.ago) do
           create(:dossier,
             state: :brouillon,
+            procedure: procedures.demo,
             brouillon_close_to_expiration_notice_sent_at: (4.months + 20.days).from_now)
         end
       end
 
       let!(:dossier_brouillon_expired_but_not_noticed_yet) do
         travel_to(5.months.ago) do
           create(:dossier,
-            state: :brouillon)
+            state: :brouillon,
+            procedure: procedures.demo)
         end
       end
 
       let!(:dossier_instruction_expired) do
         travel_to(5.months.ago) do
           create(:dossier,
             state: :en_instruction,
+            procedure: procedures.demo,
             brouillon_close_to_expiration_notice_sent_at: 1.day.ago)
         end
       end
@@ -141,6 +146,7 @@
         travel_to(5.months.ago) do
           create(:dossier,
             state: :brouillon,
+            procedure: procedures.demo,
             brouillon_close_to_expiration_notice_sent_at: 1.day.ago,
             hidden_by_user_at: Time.zone.now)
         end
@@ -159,9 +165,9 @@
     end
 
     describe '.brouillon_expired_without_notice' do
-      let(:published_procedure) { create(:procedure, :published) }
-      let(:closed_procedure)    { create(:procedure, :closed) }
-      let(:draft_procedure)     { create(:procedure, :draft) }
+      let(:published_procedure) { procedures.demo }
+      let_it_be(:closed_procedure) { create(:procedure, :closed) }
+      let_it_be(:draft_procedure)  { create(:procedure, :draft) }
 
       # targets: expired + structurally never notified
       let!(:expired_on_closed) { create(:dossier, procedure: closed_procedure).tap { |d| d.update_column(:expired_at, 1.day.ago) } }
@@ -402,7 +408,7 @@
       end
 
       context 'when the dossier belongs to a procedure for individuals' do
-        let(:procedure) { create(:procedure, for_individual: true) }
+        let(:procedure) { procedures.demo }
 
         it 'creates a default individual' do
           subject
@@ -435,7 +441,7 @@
       end
 
       context 'when the dossier belongs to a procedure for moral personas' do
-        let(:procedure) { create(:procedure, for_individual: false) }
+        let(:procedure) { procedures.entreprise }
 
         it 'doesn’t create a individual' do
           subject
@@ -445,7 +451,7 @@
     end
 
     describe '#prefill_champs_from_france_connect' do
-      let(:procedure) { create(:procedure, :for_individual, types_de_champ_public: [{ type: :date }]) }
+      let_it_be(:procedure) { create(:procedure, :for_individual, types_de_champ_public: [{ type: :date }]) }
       let(:user) { create(:user, france_connect_informations: [build(:france_connect_information)]) }
       let(:dossier) { create(:dossier, procedure:, user:) }
       let(:tdc) { procedure.active_revision.types_de_champ_public.first }
@@ -515,9 +521,8 @@
     end
 
     describe '#update_for_tiers' do
-      let(:procedure) { create(:procedure, :for_individual) }
       let(:individual) { build(:individual, nom: 'Dupont', prenom: 'Jean', gender: Individual::GENDER_MALE, birthdate: Date.new(1980, 1, 1)) }
-      let(:dossier) { create(:dossier, procedure:, user:, individual:) }
+      let(:dossier) { create(:dossier, procedure: procedures.demo, user:, individual:) }
 
       context 'when user is connected via FranceConnect with one identity' do
         let(:user) { create(:user, france_connect_informations: [build(:france_connect_information)]) }
@@ -888,13 +893,13 @@
   end
 
   describe '.with_unread_messages_for_user' do
-    let(:dossier_with_unread_instructeur) { create(:dossier, :en_construction, procedure: procedures.demo) }
-    let(:dossier_with_read_instructeur) { create(:dossier, :en_construction, procedure: procedures.demo) }
-    let(:dossier_with_unread_expert) { create(:dossier, :en_construction, procedure: procedures.demo) }
-    let(:dossier_with_only_usager_message) { create(:dossier, :en_construction, procedure: procedures.demo) }
-    let(:dossier_with_discarded_unread) { create(:dossier, :en_construction, procedure: procedures.demo) }
+    let_it_be(:dossier_with_unread_instructeur) { create(:dossier, :en_construction, procedure: procedures.demo) }
+    let_it_be(:dossier_with_read_instructeur) { create(:dossier, :en_construction, procedure: procedures.demo) }
+    let_it_be(:dossier_with_unread_expert) { create(:dossier, :en_construction, procedure: procedures.demo) }
+    let_it_be(:dossier_with_only_usager_message) { create(:dossier, :en_construction, procedure: procedures.demo) }
+    let_it_be(:dossier_with_discarded_unread) { create(:dossier, :en_construction, procedure: procedures.demo) }
 
-    before do
+    before_all do
       create(:commentaire, dossier: dossier_with_unread_instructeur, instructeur: create(:instructeur), seen_by_recipient_at: nil)
       create(:commentaire, dossier: dossier_with_read_instructeur, instructeur: create(:instructeur), seen_by_recipient_at: 1.day.ago)
       create(:commentaire, dossier: dossier_with_unread_expert, expert: create(:expert), seen_by_recipient_at: nil)
@@ -1112,22 +1117,34 @@
   end
 
   describe "#unspecified_attestation_champs" do
-    let(:procedure) { create(:procedure, attestation_acceptation_template:, types_de_champ_public:, types_de_champ_private:) }
-    let(:dossier) { create(:dossier, :en_instruction, procedure:) }
+    def types_de_champ_public
+      [
+        { libelle: "specified champ-in-title" },
+        { libelle: "unspecified champ-in-title" },
+        { libelle: "specified champ-in-body" },
+        { libelle: "unspecified champ-in-body" },
+      ]
+    end
 
-    let(:types_de_champ_public) { [tdc_1, tdc_2, tdc_3, tdc_4] }
-    let(:types_de_champ_private) { [tdc_5, tdc_6, tdc_7, tdc_8] }
+    def types_de_champ_private
+      [
+        { libelle: "specified annotation privée-in-title" },
+        { libelle: "unspecified annotation privée-in-title" },
+        { libelle: "specified annotation privée-in-body" },
+        { libelle: "unspecified annotation privée-in-body" },
+      ]
+    end
 
-    let(:tdc_1) { { libelle: "specified champ-in-title" } }
-    let(:tdc_2) { { libelle: "unspecified champ-in-title" } }
-    let(:tdc_3) { { libelle: "specified champ-in-body" } }
-    let(:tdc_4) { { libelle: "unspecified champ-in-body" } }
-    let(:tdc_5) { { libelle: "specified annotation privée-in-title" } }
-    let(:tdc_6) { { libelle: "unspecified annotation privée-in-title" } }
-    let(:tdc_7) { { libelle: "specified annotation privée-in-body" } }
-    let(:tdc_8) { { libelle: "unspecified annotation privée-in-body" } }
+    let_it_be(:procedure) { create(:procedure, types_de_champ_public:, types_de_champ_private:) }
+    let_it_be(:dossier) { create(:dossier, :en_instruction, procedure:) }
 
     before do
+      # reset association caches: each example rolls back to the group snapshot
+      procedure.reload
+      dossier.reload
+
+      procedure.attestation_acceptation_template = attestation_acceptation_template if attestation_acceptation_template
+
       (dossier.project_champs_public + dossier.project_champs_private)
         .filter { |c| c.libelle.match?(/^specified/) }
         .each { |c| c.update_attribute(:value, "specified") }
@@ -1586,7 +1603,7 @@
   describe '#accepter_automatiquement!' do
     let(:last_operation) { dossier.dossier_operation_logs.last }
     let!(:now) { Time.zone.parse('01/01/2100') }
-    let(:procedure) { create(:procedure, :for_individual, :published) }
+    let(:procedure) { procedures.demo }
     let!(:attestation_template) { create(:attestation_template, procedure:, kind: :acceptation, state: :published) }
 
     before do
@@ -1621,7 +1638,7 @@
     end
 
     context 'as sva procedure' do
-      let(:procedure) { create(:procedure, :for_individual, :published, :sva) }
+      let_it_be(:procedure) { create(:procedure, :for_individual, :published, :sva) }
       let(:dossier) { create(:dossier, :en_instruction, :with_individual, procedure:, sva_svr_decision_on: Date.current, en_instruction_at: DateTime.new(2021, 5, 1, 12)) }
       let!(:attestation_template) { create(:attestation_template, procedure:, kind: :acceptation, state: :published) }
 
@@ -1644,7 +1661,7 @@
   describe '#refuser_automatiquement' do
     context 'as svr procedure' do
       let(:last_operation) { dossier.dossier_operation_logs.last }
-      let(:procedure) { create(:procedure, :for_individual, :published, :svr) }
+      let_it_be(:procedure) { create(:procedure, :for_individual, :published, :svr) }
       let(:dossier) { create(:dossier, :en_instruction, :with_individual, procedure:, sva_svr_decision_on: Date.current, en_instruction_at: DateTime.new(2021, 5, 1, 12)) }
 
       before {
@@ -1722,7 +1739,7 @@
     let(:instructeur) { create(:instructeur) }
 
     context "via procedure declarative en instruction" do
-      let(:dossier) { create(:dossier, :en_construction, :with_declarative_en_instruction) }
+      let(:dossier) { create(:dossier, :en_construction, :with_declarative_en_instruction, procedure: procedures.demo) }
 
       subject do
         dossier.process_declarative!
@@ -1742,7 +1759,7 @@
     end
 
     context "via procedure sva" do
-      let(:procedure) { create(:procedure, :sva, :published, :for_individual) }
+      let_it_be(:procedure) { create(:procedure, :sva, :published, :for_individual) }
       let(:dossier) { create(:dossier, :en_construction, :with_individual, procedure:, sva_svr_decision_on: 10.days.from_now) }
       let(:sva_svr_decision_on) { SVASVRDecisionDateCalculatorService.new(dossier, procedure).decision_date }
 
@@ -2047,10 +2064,9 @@
 
   describe "can't transition to terminer when annotations privees are not valid" do
     let(:instructeur) { create(:instructeur) }
-    let(:procedure) { create(:procedure, types_de_champ_private:) }
+    let_it_be(:procedure) { create(:procedure, types_de_champ_private: [{ type: :text, mandatory: true }]) }
     let(:dossier_incomplete) { create(:dossier, :en_instruction, procedure:) }
     let(:dossier_ok) { create(:dossier, :en_instruction, :with_populated_annotations, procedure:) }
-    let(:types_de_champ_private) { [{ type: :text, mandatory: true }] }
 
     context "when dossier is en_instruction" do
       it "can't accepter" do
@@ -2873,10 +2889,10 @@
   end
 
   describe '#archivable_by_month' do
-    let(:procedure) { create(:procedure, :published, groupe_instructeurs: [groupe_instructeurs]) }
-    let(:groupe_instructeurs) { create(:groupe_instructeur) }
+    let_it_be(:groupe_instructeurs) { create(:groupe_instructeur) }
+    let_it_be(:procedure) { create(:procedure, :published, groupe_instructeurs: [groupe_instructeurs]) }
 
-    before do
+    before_all do
       create_dossier_for_month(procedure, 2021, 3)
       create_dossier_for_month(procedure, 2021, 3)
       create_archived_dossier_for_month(procedure, 2021, 3)