Skip to content

Commit fb06629

Browse files
authored
Den 226 Fix wait_for_changes timeout #38
1 parent 34f8ddc commit fb06629

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

dendrite_sdk/_core/dendrite_element.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -225,10 +225,14 @@ async def _wait_for_page_changes(self, old_url: str, timeout: float = 2000):
225225
Returns:
226226
bool: True if the page changed, False otherwise.
227227
"""
228+
# Convert the timeout from milliseconds to seconds
229+
timeout_in_seconds = timeout / 1000
228230
start_time = time.time()
229-
while time.time() - start_time <= timeout:
231+
232+
while time.time() - start_time <= timeout_in_seconds:
230233
page = await self._dendrite_browser.get_active_page()
231234
if page.url != old_url:
232235
return True
233-
await asyncio.sleep(0.1)
236+
await asyncio.sleep(0.1) # Wait briefly before checking again
237+
234238
return False

0 commit comments

Comments
 (0)