fix: ensure headers are cached and loaded properly (#8)

Author: dsherret

src/rs_lib/http_client.rs

@@ -6,10 +6,12 @@ use deno_cache_dir::file_fetcher::SendResponse;
 use deno_cache_dir::file_fetcher::StatusCode;
 use deno_error::JsErrorBox;
 use deno_npm_cache::NpmCacheHttpClientResponse;
+use js_sys::Array;
 use js_sys::Object;
 use js_sys::Reflect;
 use serde::Deserialize;
 use url::Url;
+use wasm_bindgen::JsCast;
 use wasm_bindgen::JsValue;
 use wasm_bindgen::prelude::wasm_bindgen;
 
@@ -200,20 +202,27 @@ fn parse_response(js_value: JsValue) -> Result<Response, JsValue> {
 
 fn response_headers_to_headermap(headers: JsValue) -> HeaderMap {
   let mut map = HeaderMap::new();
-
-  if !headers.is_object() {
+  let entries_fn = Reflect::get(&headers, &JsValue::from_str("entries"));
+  let Ok(entries_fn) = entries_fn else {
     return map;
-  }
+  };
 
-  let obj = Object::from(headers);
-  let entries = Object::entries(&obj);
+  let entries_iter = js_sys::Function::from(entries_fn)
+    .call0(&headers)
+    .ok()
+    .and_then(|iter| iter.dyn_into::<js_sys::Iterator>().ok());
 
-  for i in 0..entries.length() {
-    let entry = entries.get(i);
-    if !entry.is_object() {
-      continue;
+  let Some(iter) = entries_iter else {
+    return map;
+  };
+
+  while let Ok(next) = iter.next() {
+    if next.done() {
+      break;
     }
-    let pair = js_sys::Array::from(&entry);
+
+    let val = next.value();
+    let pair = Array::from(&val);
     if pair.length() != 2 {
       continue;
     }

src/rs_lib/lib.rs

@@ -566,7 +566,15 @@ impl DenoLoader {
         Cow::Borrowed(&transpile_and_emit_options.transpile)
       };
       let emit_options = EmitOptions {
-        source_map_base: Some(self.workspace_factory.workspace_directory()?.workspace.root_dir().as_ref().clone()),
+        source_map_base: Some(
+          self
+            .workspace_factory
+            .workspace_directory()?
+            .workspace
+            .root_dir()
+            .as_ref()
+            .clone(),
+        ),
         ..transpile_and_emit_options.emit.clone()
       };
       let transpiled_source = parsed_source
@@ -632,6 +640,7 @@ fn parse_entrypoint(
 ) -> Result<Url, anyhow::Error> {
   if entrypoint.starts_with("jsr:")
     || entrypoint.starts_with("https:")
+    || entrypoint.starts_with("http:")
     || entrypoint.starts_with("file:")
     || entrypoint.starts_with("npm:")
   {

tests/http_no_ext.test.ts

@@ -0,0 +1,22 @@
+import { assertResponseText, createLoader } from "./helpers.ts";
+
+Deno.test("loads from http server", async () => {
+  await using server = Deno.serve((_request) => {
+    return new Response("console.log(1);", {
+      headers: {
+        "content-type": "application/javascript",
+      },
+    });
+  });
+
+  const url = `http://localhost:${server.addr.port}/no-extension`;
+  const { loader } = await createLoader({}, {
+    entrypoints: [url],
+  });
+
+  const response = await loader.load(url);
+  assertResponseText(
+    response,
+    `console.log(1);`,
+  );
+});