Skip to content

Commit 08cc221

Browse files
littledivykt3k
andauthored
fix(ext/node): set process.env as own property (#27891)
Fixes `[email protected]` ``` % deno eval "import 'npm:[email protected]'" # main error: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'GOOGLE_SDK_NODE_LOGGING') at Object.log (file:///Users/divy/Library/Caches/deno/npm/registry.npmjs.org/google-logging-utils/0.0.2/build/src/logging-utils.js:356:36) at Object.<anonymous> (file:///Users/divy/Library/Caches/deno/npm/registry.npmjs.org/gcp-metadata/6.1.1/build/src/index.js:52:20) at Object.<anonymous> (file:///Users/divy/Library/Caches/deno/npm/registry.npmjs.org/gcp-metadata/6.1.1/build/src/index.js:409:4) at Module._compile (node:module:745:34) at loadMaybeCjs (node:module:770:10) at Object.Module._extensions..js (node:module:755:12) at Module.load (node:module:662:32) at Function.Module._load (node:module:534:12) at Module.require (node:module:681:19) at require (node:module:812:16) % target/debug/deno eval "import 'npm:[email protected]'" # this PR ``` --------- Signed-off-by: Divy Srivastava <[email protected]> Co-authored-by: Yoshiya Hinosawa <[email protected]>
1 parent d9db0b3 commit 08cc221

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

ext/node/polyfills/process.ts

+1
Original file line numberDiff line numberDiff line change
@@ -780,6 +780,7 @@ const process = new Process();
780780

781781
/* Set owned property */
782782
process.versions = versions;
783+
process.env = env;
783784

784785
Object.defineProperty(process, Symbol.toStringTag, {
785786
enumerable: false,

tests/unit_node/process_test.ts

+2
Original file line numberDiff line numberDiff line change
@@ -390,6 +390,8 @@ Deno.test({
390390
Deno.test({
391391
name: "process.env",
392392
fn() {
393+
assert(Object.prototype.hasOwnProperty.call(process, "env"));
394+
393395
Deno.env.set("HELLO", "WORLD");
394396

395397
assertObjectMatch(process.env, Deno.env.toObject());

0 commit comments

Comments
 (0)