add atomic tests

Author: fraidev

libs/core/runtime/jsruntime.rs

@@ -2292,10 +2292,12 @@ impl JsRuntime {
         .safety_net_active
         .swap(true, std::sync::atomic::Ordering::SeqCst)
     {
-      let waker = cx.waker().clone();
-      let flag = self.inner.state.safety_net_active.clone();
-      waker.wake();
-      flag.store(false, std::sync::atomic::Ordering::SeqCst);
+      cx.waker().clone().wake();
+      self
+        .inner
+        .state
+        .safety_net_active
+        .store(false, std::sync::atomic::Ordering::SeqCst);
     }
 
     // Re-wake logic for next iteration

tests/specs/worker/atomics_wait_async_notify/__test__.jsonc

@@ -0,0 +1,5 @@
+{
+  "args": "test --quiet --no-check -A main.ts",
+  "output": "main.out",
+  "exitCode": 0
+}

tests/specs/worker/atomics_wait_async_notify/main.out

@@ -0,0 +1,3 @@
+atomicsWaitAsyncNotify ... ok [WILDCARD]
+
+ok | 1 passed | 0 failed [WILDCARD]

tests/specs/worker/atomics_wait_async_notify/main.ts

@@ -0,0 +1,33 @@
+// Regression test for https://github.com/denoland/deno/issues/14786
+// Atomics.waitAsync in a worker requires V8 to post a delayed foreground
+// task when the wait is resolved. Without the custom platform waking the
+// event loop, the worker hangs forever.
+Deno.test(async function atomicsWaitAsyncNotify() {
+  const ia = new Int32Array(
+    new SharedArrayBuffer(Int32Array.BYTES_PER_ELEMENT),
+  );
+
+  const p = Promise.allSettled(
+    Array(2).fill(0).map((_, i) => {
+      const w = new Worker(
+        new URL("./worker.ts", import.meta.url),
+        {
+          type: "module",
+          name: `worker-${i}`,
+        },
+      );
+      return new Promise<void>((res, rej) => {
+        w.onmessage = (ev) => {
+          if (ev.data.ok) res(ev.data);
+          else rej(ev.data);
+        };
+        setTimeout(w.postMessage.bind(w), undefined, ia);
+      }).finally(w.terminate.bind(w));
+    }),
+  );
+
+  const results = await p;
+  for (const r of results) {
+    if (r.status === "rejected") throw r.reason;
+  }
+});

tests/specs/worker/atomics_wait_async_notify/worker.ts

@@ -0,0 +1,24 @@
+const sleep = (duration: number) => {
+  return new Promise<void>((res) => {
+    setTimeout(() => res(), duration);
+  });
+};
+
+self.onmessage = async (ev) => {
+  const ia = ev.data;
+  try {
+    const actual = Atomics.compareExchange(ia, 0, 0, 1);
+
+    if (actual === 0) {
+      await sleep(0);
+      Atomics.notify(ia, 0);
+      self.postMessage({ ok: true });
+    } else {
+      let { value } = Atomics.waitAsync(ia, 0, 1);
+      value = await value;
+      self.postMessage({ ok: true });
+    }
+  } catch (err) {
+    self.postMessage({ ok: false, err });
+  }
+};