error instead of falling back to fd

Author: fraidev

ext/node/polyfills/fs.ts

@@ -400,16 +400,17 @@ function readv(
     buffers: readonly ArrayBufferView[],
     position: number | null,
   ) => {
+    const rid = getRid(fd);
     if (typeof position === "number") {
-      await op_fs_seek_async(fd, position, io.SeekMode.Start);
+      await op_fs_seek_async(rid, position, io.SeekMode.Start);
     }
 
     let readTotal = 0;
     let readInBuf = 0;
     let bufIdx = 0;
     let buf = buffers[bufIdx];
     while (bufIdx < buffers.length) {
-      const nread = await io.read(fd, buf);
+      const nread = await io.read(rid, buf);
       if (nread === null) {
         break;
       }
@@ -455,17 +456,18 @@ function readvSync(
   if (buffers.length === 0) {
     return 0;
   }
+  const rid = getRid(fd);
   if (typeof position === "number") {
     validateInteger(position, "position", 0);
-    op_fs_seek_sync(fd, position, io.SeekMode.Start);
+    op_fs_seek_sync(rid, position, io.SeekMode.Start);
   }
 
   let readTotal = 0;
   let readInBuf = 0;
   let bufIdx = 0;
   let buf = buffers[bufIdx];
   while (bufIdx < buffers.length) {
-    const nread = io.readSync(fd, buf);
+    const nread = io.readSync(rid, buf);
     if (nread === null) {
       break;
     }

ext/node/polyfills/internal/fs/fd_map.ts

@@ -4,13 +4,10 @@ import { primordials } from "ext:core/mod.js";
 import { op_node_dup_fd } from "ext:core/ops";
 
 const {
-  ErrorPrototype,
   MapPrototypeGet,
   MapPrototypeSet,
   MapPrototypeDelete,
-  ObjectPrototypeIsPrototypeOf,
   SafeMap,
-  StringPrototypeIncludes,
 } = primordials;
 
 // Maps OS file descriptors to Deno resource IDs.
@@ -37,25 +34,9 @@ export function getRid(fd: number): number {
   // and closeable. op_node_dup_fd denies fds managed by internal Deno
   // resources (non-fsFile) to prevent unauthorized access.
   if (fd >= 3) {
-    try {
-      const newRid = op_node_dup_fd(fd);
-      MapPrototypeSet(fdMap, fd, newRid);
-      return newRid;
-    } catch (e) {
-      // Unsupported means the platform doesn't support dup (Windows).
-      // Fall through to return fd as-is.
-      // For any other error (including PermissionDenied for internal Deno
-      // resources, EBADF, etc.), re-throw to prevent using the raw fd
-      // number as a resource ID.
-      if (
-        ObjectPrototypeIsPrototypeOf(ErrorPrototype, e) &&
-        StringPrototypeIncludes(e.message, "not supported")
-      ) {
-        // Fall through -- on Windows, dup is unavailable
-      } else {
-        throw e;
-      }
-    }
+    const newRid = op_node_dup_fd(fd);
+    MapPrototypeSet(fdMap, fd, newRid);
+    return newRid;
   }
   return fd;
 }