Skip to content

Commit 2cbee53

Browse files
committed
fix(ext/node): use non-blocking write in fs.writev
1 parent 8cf29d5 commit 2cbee53

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

ext/node/polyfills/fs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2096,7 +2096,7 @@ function writev(
20962096
let currentOffset = 0;
20972097
// deno-lint-ignore prefer-primordials
20982098
while (currentOffset < buffer.byteLength) {
2099-
currentOffset += await io.writeSync(fd, buffer.subarray(currentOffset));
2099+
currentOffset += await io.write(fd, buffer.subarray(currentOffset));
21002100
}
21012101
return currentOffset - offset;
21022102
};

tests/node_compat/config.jsonc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -835,6 +835,9 @@
835835
"parallel/test-fs-write-optional-params.js": {},
836836
"parallel/test-fs-write-stream-encoding.js": {},
837837
"parallel/test-fs-write-sync-optional-params.js": {},
838+
"parallel/test-fs-writev.js": {},
839+
"parallel/test-fs-writev-promises.js": {},
840+
"parallel/test-fs-writev-sync.js": {},
838841
"parallel/test-global-console-exists.js": {},
839842
"parallel/test-global-domexception.js": {},
840843
"parallel/test-global-encoder.js": {},
@@ -1596,6 +1599,7 @@
15961599
},
15971600
"parallel/test-pipe-head.js": {},
15981601
"parallel/test-pipe-return-val.js": {},
1602+
"parallel/test-pipe-writev.js": {},
15991603
"parallel/test-preload-worker.js": {},
16001604
"parallel/test-primordials-apply.js": {
16011605
"ignore": true,

0 commit comments

Comments
 (0)