review

Author: bartlomieju

ext/node_crypto/primes.rs

@@ -25,6 +25,11 @@ impl Prime {
   /// When `add` is set but `rem` is not:
   /// - If safe is false, rem defaults to 1
   /// - If safe is true, rem defaults to 3
+  ///
+  /// This follows the same algorithm as OpenSSL's BN_generate_prime_ex():
+  /// generate random candidates in [2^(n-1), 2^n), adjust to satisfy the
+  /// add/rem constraint, then test with Miller-Rabin. For safe primes,
+  /// also verify (p-1)/2 is prime.
   pub fn generate_with_options(
     n: usize,
     safe: bool,

tests/node_compat/config.jsonc

@@ -412,6 +412,7 @@
     "parallel/test-crypto-psychic-signatures.js": {},
     "parallel/test-crypto-randomfillsync-regression.js": {},
     "parallel/test-crypto-randomuuid.js": {},
+    "parallel/test-crypto-prime.js": {},
     "parallel/test-crypto-rsa-pss-default-salt-length.js": {},
     "parallel/test-crypto-sec-level.js": {},
     "parallel/test-crypto-secret-keygen.js": {},