Skip to content

Commit f01347e

Browse files
authored
ci: fix release rebuilding on prs (#32210)
1 parent 3550a05 commit f01347e

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

.github/workflows/ci.generate.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -769,8 +769,8 @@ const buildJobs = buildItems.map((rawBuildItem) => {
769769
sysRootStep,
770770
)(
771771
{
772+
// do this on PRs as well as main so that PRs can use the cargo build cache from main
772773
name: "Configure canary build",
773-
if: isMainBranch,
774774
run: 'echo "DENO_CANARY=true" >> $GITHUB_ENV',
775775
},
776776
{

.github/workflows/ci.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ jobs:
587587
- uses: dsherret/rust-toolchain-file@v1
588588
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'')'
589589
- name: Configure canary build
590-
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'') && github.repository == ''denoland/deno'' && github.ref == ''refs/heads/main'''
590+
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'') && github.repository == ''denoland/deno'''
591591
run: echo "DENO_CANARY=true" >> $GITHUB_ENV
592592
- name: Build release
593593
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'') && github.repository == ''denoland/deno'''
@@ -1384,7 +1384,7 @@ jobs:
13841384
- uses: dsherret/rust-toolchain-file@v1
13851385
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'')'
13861386
- name: Configure canary build
1387-
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'') && github.repository == ''denoland/deno'' && github.ref == ''refs/heads/main'''
1387+
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'') && github.repository == ''denoland/deno'''
13881388
run: echo "DENO_CANARY=true" >> $GITHUB_ENV
13891389
- name: Build release
13901390
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'') && github.repository == ''denoland/deno'''
@@ -2111,7 +2111,7 @@ jobs:
21112111
- uses: dsherret/rust-toolchain-file@v1
21122112
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'')'
21132113
- name: Configure canary build
2114-
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'') && github.repository == ''denoland/deno'' && github.ref == ''refs/heads/main'''
2114+
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'') && github.repository == ''denoland/deno'''
21152115
run: echo "DENO_CANARY=true" >> $GITHUB_ENV
21162116
- name: Build release
21172117
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'') && github.repository == ''denoland/deno'''
@@ -2764,7 +2764,7 @@ jobs:
27642764
- uses: dsherret/rust-toolchain-file@v1
27652765
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'')'
27662766
- name: Configure canary build
2767-
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'') && github.repository == ''denoland/deno'' && github.ref == ''refs/heads/main'''
2767+
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'') && github.repository == ''denoland/deno'''
27682768
run: echo "DENO_CANARY=true" >> $GITHUB_ENV
27692769
- name: Build release
27702770
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'') && github.repository == ''denoland/deno'''
@@ -3226,7 +3226,6 @@ jobs:
32263226
CFLAGS=$CFLAGS
32273227
" > $GITHUB_ENV
32283228
- name: Configure canary build
3229-
if: github.ref == 'refs/heads/main'
32303229
run: echo "DENO_CANARY=true" >> $GITHUB_ENV
32313230
- name: Build release
32323231
run: |-
@@ -4790,7 +4789,7 @@ jobs:
47904789
CFLAGS=$CFLAGS
47914790
" > $GITHUB_ENV
47924791
- name: Configure canary build
4793-
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'') && github.ref == ''refs/heads/main'''
4792+
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'')'
47944793
run: echo "DENO_CANARY=true" >> $GITHUB_ENV
47954794
- name: Build release
47964795
if: '!(!contains(github.event.pull_request.labels.*.name, ''ci-full'') && github.event_name == ''pull_request'')'

0 commit comments

Comments
 (0)