Invalid promise id with async code and deno_core

[fcoury]

I am trying to run the following code:

use std::rc::Rc;

use deno_core::{
    error::AnyError,
    op,
    v8::{self},
    Extension,
};
use serde_json::Value;

#[tokio::main]
async fn main() -> Result<(), AnyError> {
    let code = r#"
    async function foo() {
        return await Deno.core.opAsync("op_sample");
    }
    foo();
    "#;

    let extension = Extension::builder().ops(vec![op_sample::decl()]).build();
    let mut js_runtime = deno_core::JsRuntime::new(deno_core::RuntimeOptions {
        module_loader: Some(Rc::new(deno_core::FsModuleLoader)),
        extensions: vec![extension],
        ..Default::default()
    });
    let global = js_runtime.execute_script("<anon>", code)?;
    js_runtime.run_event_loop(false).await?;

    let scope = &mut js_runtime.handle_scope();
    let local = v8::Local::new(scope, global);
    // Deserialize a `v8` object into a Rust type using `serde_v8`,
    // in this case deserialize to a JSON `Value`.
    let value = serde_v8::from_v8::<Value>(scope, local)?;
    println!("{:?}", value);

    Ok(())
}

#[op]
async fn op_sample() -> Result<Value, AnyError> {
    Ok(Value::String("something".to_string()))
}

But getting the error:

Error: TypeError: invalid promise id: expected type `v8::data::Integer`, got `v8::data::Value`
    at Object.opAsync (deno:core/01_core.js:229:23)
    at foo (<anon>:3:32)
    at <anon>:5:5

Any ideas how to make this work?

Online replit: https://replit.com/@fcoury/DenoCoreAsync?v=1

[bartlomieju]

@littledivy PTAL, feel like it's something related to your recent changes

[fcoury]

Some additional information:

1. Reverting to deno_core = "0.149.0" and serde_v8 = "0.62.0" works.
2. After some feedback from @bartlomieju and @littledivy on the Discord server, I figured that if you add Deno.core.initializeAsyncOps() as the first line of the code variable it also works on latest versions (as time of writing deno_core = "0.157.0" and serde_v8 = "0.68.0").

Thank you both.

[Wyatex]

When I call initializeAsyncOps, an error occurs.

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: TypeError: core.initializeAsyncOps is not a function

Have you encountered this problem? Here is my issue link.

[fcoury]

I think in latest deno versions you don't need core.initializeAsyncOps anymore.

[Wyatex]

The above problem has been solved, but I have encountered a new problem.
I want to add a runtime.js, but if I write it this way, an error will occur.

js_runtime.execute_script("[runjs:runtime.js]",  include_str!("./runtime.js")).unwrap();

error[E0308]: mismatched types
    --> src\main.rs:40:54
     |
40   |     js_runtime.execute_script("[runjs:runtime.js]",  include_str!("./runtime.js")).unwrap();
     |                --------------                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `FastString`, found `&str`
     |                |
     |                arguments to this method are incorrect
     |

Then I switched to the esm mode, and it also reported an error.

    let runjs_extension = Extension::builder("runjs")
        .esm(include_js_files!("src/runtime.js"))
        .build();

error: no rules expected the token `"src/runtime.js"`
   --> src\main.rs:28:32
    |
28  |         .esm(include_js_files!("src/runtime.js"))
    |                                ^^^^^^^^^^^^^^^^ no rules expected this token in macro call
    |

I'm a Rust beginner, can you teach me how to change it to solve this error?