fix(cli): add support for node-api in deno compile
#24775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mutefish0
force-pushed
the
fix-standalone-napi-v2
branch
from
046e569 to
c09fa16
Compare
|
this caused a duplicate symbol issue when publishing, which was separate from the other issue. |
|
This was done in 79a3ad2. Note that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #24614
this PR relands #24642, which was previously reverted due to a publishing issue:
https://github.com/denoland/deno/actions/runs/10048730693/job/27773718095#step:7:8506
The publishing issue may be introduced by another PR (which has been reverted) that changed the
symbols_pathto a relative path(perhaps publishing is running in a different cwd compared to building?), causing it to be missing during publishing：https://github.com/denoland/deno/pull/24680/files#diff-fa76844bfec3519648a2d7493933ff3317fa3250dd913cc26d0e86b3b5d4465aL399