Using `Buffer` no longer works after upgrading to Deno v2

[bombillazo]

Version: Deno 2+

Hello, after upgrading to Deno v2, our use of Buffer no longer works. We get the following error:

error: TS2576 [ERROR]: Property 'from' does not exist on type 'Buffer'. Did you mean to access the static member 'Buffer.from' instead?
    Buffer.from(data, 'base64').toString('utf-8')

We are importing with

import { Buffer } from 'buffer';

{
  "imports": {
    "buffer": "node:buffer",
  }
}

If also tried https://deno.land/std/io/buffer.ts and @std/io/buffer

[bartlomieju]

@bombillazo would you be able to provide a reproduction for this bug? Eg. a repository that exhibits this behavior?

With this file (main.js):

import { Buffer } from "node:buffer";

Buffer.from([1, 2, 3], "base64").toString("utf-8")

and running:

deno run main.js

I can't reproduce the problem on Deno v2.1.4.

[bombillazo]

Sorry for the missing context. Try deno compile since that's the command that fails.

[bartlomieju]

@bombillazo sadly I can't reproduce it on either v2.1.4 or latest canary. I would appreciate a reproduction to help track down this problem.

[bombillazo]

this is our deno.jsonr

{
  "compilerOptions": {
    // TODO: remove this rule to use default and type check errors
    "useUnknownInCatchVariables": false
  },
  "nodeModulesDir": "auto",
  "importMap": "./backend/import_map.json",
  "lint": {
    "rules": {
      "exclude": [
        "no-explicit-any",
        "no-empty-interface",
        "require-await"
      ],
      "include": [
        "no-case-declarations",
        "no-dupe-else-if",
        "no-dupe-keys",
        "no-duplicate-case",
        "no-func-assign",
        "no-unused-vars"
      ]
    }
  },
  "fmt": {
    "singleQuote": true
  },
  "exclude": [
      ".next/",
      ".*.js",
      "**/*.js",
      "**/*.cjs",
      "**/*.local.ts",
      "**/*.test.ts",
      "backend/.bin",
      "backend/core/.deps/",
      "dashboard/",
      "node_modules/",
      "src/"
    ]
}

[bombillazo]

Heres whay I see when I inspect Buffer in my code

[bombillazo]

We were able to migrate using jsr:@std/encoding to replace Buffer, which works on both node and deno. We updated our code to use the appropriate functions that Buffer users with the encoding lib ones.

We also had to add "moduleResolution" to "bundler" in our tsconfig file since keeping it as node gave us this error:

Cannot find module '@std/encoding' or its corresponding type declarations.
  There are types at '/Users/app/node_modules/@std/encoding/_dist/mod.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.ts(2307)

[bombillazo]

@bartlomieju I tried reporducing the bug on a codesandbox but I am unable, it seems tied to out whole project setup/structure... :/

Using the debug flag, this is the last thing outputted:

DEBUG RS - deno::tools::check:280 - Compilation statistics:
  Files: 1933
  Nodes: 1274831
  Identifiers: 369605
  Symbols: 243276
  Types: 89
  Instantiations: 0
  Parse time: 977
  Bind time: 448
  Check time: 0
  Emit time: 0
  Total TS time: 1425
  Compile time: 1939

TRACE RS - deno::cache::cache_db:142 - Cleaned up SQLite connection at /Users/Library/Caches/deno/fast_check_cache_v2
TRACE RS - deno::cache::cache_db:142 - Cleaned up SQLite connection at /Users/Library/Caches/deno/dep_analysis_cache_v2
TRACE RS - deno::cache::cache_db:142 - Cleaned up SQLite connection at /Users/Library/Caches/deno/check_cache_v2
error: TS2576 [ERROR]: Property 'from' does not exist on type 'Buffer'. Did you mean to access the static member 'Buffer.from' instead?
    Uint8Array.from(Buffer.from(hash)),

Its as if Deno seed a different Buffer location, not sure if from node_modules or someplace else. This was not happening in V 1.46.3