Exception when calling fs.close() without callback

[ben-stockett]

Version: Deno 2.5.0

The Deno implementation of the Node file system API seems to require a callback.

But the callback should be optional according to the Node documentation:
https://nodejs.org/api/fs.html#fsclosefd-callback

Minimal example:

import * as fs from "node:fs";

const fd = fs.openSync("some_file", "r");
fs.close(fd);

Exception thrown:

error: Uncaught TypeError: callback is not a function
    at ext:deno_node/_fs/_fs_close.ts:17:5
    at callback (ext:deno_web/02_timers.js:58:7)
    at eventLoopTick (ext:core/01_core.js:214:13)

[LaneSun]

Same issue on Deploy EA:

Executing build command
Task  deno task build
Task build vite build
▲ [WARNING] Cannot find base config file "./.svelte-kit/tsconfig.json" [tsconfig.json]

    tsconfig.json:2:12:
      2 │   "extends": "./.svelte-kit/tsconfig.json",
        ╵              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error: Uncaught TypeError: callback is not a function
    at ext:deno_node/_fs/_fs_close.ts:17:5
    at callback (ext:deno_web/02_timers.js:58:7)
    at eventLoopTick (ext:core/01_core.js:214:13)
(exit code 1)

[Tango992]

It was caused by this PR #30679 . Will fix

[Lqm1]

It was caused by this PR #30679 . Will fix

When will you release a version that addresses this issue?
Also, will downgrading solve the problem?

In my environment, it does not happen on Windows, but on Linux (Alpine Docker).
This problem still occurs after downgrading. When I checked the PR mentioned, it looked like the content of 2.5.0, so I downgraded to 2.4.5, but it didn't work.

[bartlomieju]

It will be released in 2.5.1 later this week, in the meantime you can upgrade to canary version (deno upgrade canary)

[Lqm1]

It will be released in 2.5.1 later this week, in the meantime you can upgrade to canary version (deno upgrade canary)

Thank you for your quick reply.
I was able to confirm the operation without any problems. As soon as the official version is released, we will apply it to the production environment.

[nestarz]

@bartlomieju it seems Deno Deploy EA is using Deno with this regression which breaks all existing workflows that use fs.close and the error don't say where it's used. Do you think EA team can use the canary version or we are stuck until a new release ?

[AleksanderGPL]

In my environment, it does not happen on Windows, but on Linux (Alpine Docker). This problem still occurs after downgrading. When I checked the PR mentioned, it looked like the content of 2.5.0, so I downgraded to 2.4.5, but it didn't work.

@Lqm1 Same here with downgrades not fixing it, It’s really weird, works for me on Mac but not on my Linux machine where I do deployments.

[tyhrstan]

In my environment, it does not happen on Windows, but on Linux (Alpine Docker). This problem still occurs after downgrading. When I checked the PR mentioned, it looked like the content of 2.5.0, so I downgraded to 2.4.5, but it didn't work.

@Lqm1 Same here with downgrades not fixing it, It’s really weird, works for me on Mac but not on my Linux machine where I do deployments.

@bartlomieju I'm confused 😕 how is it possible that downgrading isn't solving this issue. When its introduced in 2.5.0?

[tugrulates]

Prior versions are also failing on Vercel build machines. Not reproing on my Mac.