using deno add with a jsr dep when there is a package.json should not create a deno.json

[sigmaSd]

Version: Deno 2.7.4 linux

if there is a package.json and no deno.json

using deno add npm:somdep do the expected thing and adds the dep to package.json

but using deno add jsr:somedep creates a deno.json and add it there instead of the expected thing of adding to package.json (specially now that deno handles jsr deps inside package.json)

[dataCenter430]

Hey, @sigmaSd thanks for reporting this.
I'd love to take this, if you're okay.
could you please assign it to me or may I pick this up?

[sigmaSd]

Hello @dataCenter430 I'm not a deno maintainer feel free to pick this up if you want

[dataCenter430]

thanks, I'm on it now.

[dataCenter430]

Hi, @sigmaSd
before open a PR, I have one question for my approaches:

1. Approach 1 – Only change load_configs
   In load_configs, stop using JSR to decide whether to create deno.json. Use: “if package.json exists, don’t create deno.json”:
   • Replace
     None if npm_config.is_some() && !has_jsr_specifiers() =>
     with
     None if npm_config.is_some() =>
   • Remove the has_jsr_specifiers parameter and its use in add().
     Then, when only package.json exists, deno_config stays None, so the existing add loop already sends JSR to npm_config (package.json). No change needed in the add loop.
2. Approach 2 – load_configs + add loop
   Same load_configs change as in Approach 1. In addition, make the add loop treat “prefer package.json” as “write both npm and JSR to package.json”: when prefer_npm_config and npm_config is some, always call npm_config.add(...) for every package (npm and JSR); use deno_config only when not preferring package.json. Same behavior as Approach 1, but the rule is explicit in the add loop.

once you clarify the best practice for your issue, I'll implement it closely.
Best regards

[sigmaSd]

Are you a claude claw or whatever they call it? In any case both approach seems legitimate, maybe 1 is simpler, but I would wait for an input from an actual maintainer to see what do they think

[dsherret]

@dataCenter430 please don't work on this. Even though it will likely be done, it's not listed as an agreed feature and the exact workings of this haven't been discussed yet.