Skip to content

Commit bd4d478

Browse files
authored
chore(ops): Update README with #[smi] support (#87)
1 parent 482ffcf commit bd4d478

File tree

4 files changed

+36
-10
lines changed

4 files changed

+36
-10
lines changed

ops/op2/README.md

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,20 @@ Uint32, Int32, Number, BigInt
144144
<tr>
145145
<td>
146146

147+
```rust
148+
#[smi] ResourceId
149+
```
150+
151+
</td><td>
152+
153+
</td><td>
154+
Uint32, Int32, Number, BigInt
155+
</td><td>
156+
157+
</td></tr>
158+
<tr>
159+
<td>
160+
147161
```rust
148162
#[bigint] i64
149163
```
@@ -782,6 +796,20 @@ Uint32
782796
<tr>
783797
<td>
784798

799+
```rust
800+
#[smi] ResourceId
801+
```
802+
803+
</td><td>
804+
805+
</td><td>
806+
Int32
807+
</td><td>
808+
809+
</td></tr>
810+
<tr>
811+
<td>
812+
785813
```rust
786814
#[bigint] i64
787815
```

ops/op2/mod.rs

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -472,8 +472,8 @@ deno_ops_compile_test_runner::prelude!();";
472472
let md = include_str!("valid_args.md");
473473
let separator = "\n<!-- START ARGS -->\n";
474474
let end_separator = "\n<!-- END ARGS -->\n";
475-
let (header, remainder) =
476-
split_readme(include_str!("README.md"), separator, end_separator);
475+
let readme = std::fs::read_to_string("op2/README.md").unwrap();
476+
let (header, remainder) = split_readme(&readme, separator, end_separator);
477477

478478
let mut actual = format!("{header}{separator}<table><tr><th>Rust</th><th>Fastcall</th><th>v8</th></tr>\n");
479479

@@ -517,10 +517,8 @@ deno_ops_compile_test_runner::prelude!();";
517517
std::fs::write("op2/README.md", actual)
518518
.expect("Failed to write expectation file");
519519
} else {
520-
let expected = std::fs::read_to_string("op2/README.md")
521-
.expect("Failed to read expectation file");
522520
assert_eq!(
523-
expected, actual,
521+
readme, actual,
524522
"Failed to match expectation. Use UPDATE_EXPECTED=1."
525523
);
526524
}
@@ -533,8 +531,8 @@ deno_ops_compile_test_runner::prelude!();";
533531
let md = include_str!("valid_retvals.md");
534532
let separator = "\n<!-- START RV -->\n";
535533
let end_separator = "\n<!-- END RV -->\n";
536-
let (header, remainder) =
537-
split_readme(include_str!("README.md"), separator, end_separator);
534+
let readme = std::fs::read_to_string("op2/README.md").unwrap();
535+
let (header, remainder) = split_readme(&readme, separator, end_separator);
538536
let mut actual = format!("{header}{separator}<table><tr><th>Rust</th><th>Fastcall</th><th>v8</th></tr>\n");
539537

540538
parse_md(md, |line, components| {
@@ -578,10 +576,8 @@ deno_ops_compile_test_runner::prelude!();";
578576
std::fs::write("op2/README.md", actual)
579577
.expect("Failed to write expectation file");
580578
} else {
581-
let expected = std::fs::read_to_string("op2/README.md")
582-
.expect("Failed to read expectation file");
583579
assert_eq!(
584-
expected, actual,
580+
readme, actual,
585581
"Failed to match expectation. Use UPDATE_EXPECTED=1."
586582
);
587583
}

ops/op2/valid_args.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
| X | u16 | X | Uint32, Int32, Number, BigInt | |
88
| X | i32 | X | Uint32, Int32, Number, BigInt | |
99
| X | u32 | X | Uint32, Int32, Number, BigInt | |
10+
| X | #[smi] ResourceId | X | Uint32, Int32, Number, BigInt | |
1011
| X | #[bigint] i64 | X | Uint32, Int32, Number, BigInt | |
1112
| X | #[bigint] u64 | X | Uint32, Int32, Number, BigInt | |
1213
| X | #[bigint] isize | X | Uint32, Int32, Number, BigInt | |

ops/op2/valid_retvals.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
| X | u16 | X | Uint32 | |
88
| X | i32 | X | Int32 | |
99
| X | u32 | X | Uint32 | |
10+
| X | #[smi] ResourceId | X | Int32 | |
1011
| X | #[bigint] i64 | | BigInt | |
1112
| X | #[bigint] u64 | | BigInt | |
1213
| X | #[bigint] isize | | BigInt | |

0 commit comments

Comments
 (0)