Skip to content

Commit d67efcb

Browse files
authored
feat: Add Cargo feature for V8 pointer compression (#1087)
Closes #1086
1 parent 8a2a1ea commit d67efcb

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

.github/workflows/ci-coverage/action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ runs:
77
- name: Generate code coverage
88
shell: bash
99
run: |
10-
cargo llvm-cov --workspace --release --all-features --bins --tests --examples --exclude deno_ops_compile_test_runner --lcov --output-path lcov.info
10+
cargo llvm-cov --workspace --release --features "deno_core/default deno_core/include_js_files_for_snapshotting deno_core/unsafe_runtime_options deno_core/unsafe_use_unprotected_platform" --bins --tests --examples --exclude deno_ops_compile_test_runner --lcov --output-path lcov.info
1111
- name: Upload coverage to Codecov
1212
uses: codecov/codecov-action@v4
1313
with:

.github/workflows/ci-test/action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ runs:
55
- name: Cargo test
66
shell: bash
77
run: |-
8-
cargo nextest run --workspace --release --all-features --tests --examples --exclude deno_ops_compile_test_runner
8+
cargo nextest run --workspace --release --features "deno_core/default deno_core/include_js_files_for_snapshotting deno_core/unsafe_runtime_options deno_core/unsafe_use_unprotected_platform" --tests --examples --exclude deno_ops_compile_test_runner
99
cargo test --doc
1010
1111
- name: Run examples

core/Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ path = "lib.rs"
1717
default = ["include_icu_data", "v8_use_custom_libcxx"]
1818
include_icu_data = ["deno_core_icudata"]
1919
v8_use_custom_libcxx = ["v8/use_custom_libcxx"]
20+
v8_enable_pointer_compression = ["v8/v8_enable_pointer_compression"]
2021
include_js_files_for_snapshotting = []
2122
unsafe_runtime_options = []
2223
unsafe_use_unprotected_platform = []

tools/check.ts

+5-2
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,9 @@ async function runCommands(
166166
}
167167
}
168168

169+
const CLIPPY_FEATURES =
170+
`deno_core/default deno_core/include_js_files_for_snapshotting deno_core/unsafe_runtime_options deno_core/unsafe_use_unprotected_platform`;
171+
169172
export async function main(command: string, flag: string) {
170173
if (command == "format") {
171174
const check = flag == "--check";
@@ -184,7 +187,7 @@ export async function main(command: string, flag: string) {
184187
await runCommands("Linting (--fix)", {
185188
"copyright": $`tools/copyright_checker.js --fix`,
186189
"cargo clippy":
187-
$`cargo clippy --fix --allow-dirty --allow-staged --locked --release --all-features --all-targets -- -D clippy::all`,
190+
$`cargo clippy --fix --allow-dirty --allow-staged --locked --release --features ${CLIPPY_FEATURES} --all-targets -- -D clippy::all`,
188191
});
189192
} else {
190193
await runCommands("Linting", {
@@ -196,7 +199,7 @@ export async function main(command: string, flag: string) {
196199
"tsc":
197200
$`deno run --allow-read --allow-env npm:[email protected]/tsc --noEmit -p testing/tsconfig.json`,
198201
"cargo clippy":
199-
$`cargo clippy --locked --release --all-features --all-targets -- -D clippy::all`,
202+
$`cargo clippy --locked --release --features ${CLIPPY_FEATURES} --all-targets -- -D clippy::all`,
200203
});
201204
}
202205
}

0 commit comments

Comments
 (0)