load_main_es_module_from_code doesn't call ModuleLoader#resolve to transpile Typescript to Javascript code

[taikulawo]

Version: Deno 2.4.5

I want to load typescript code string as main module, But load_main_es_module_from_code doesn't call my TypescriptModuleLoader to transpile to Javascript first.

deno_core/core/runtime/jsrealm.rs

Lines 496 to 502 in adb2f6a

	if let Some(code) = code {
	let scope = &mut self.handle_scope(isolate);
	// true for main module
	module_map_rc
	.new_es_module(scope, true, specifier.to_owned(), code, false, None)
	.map_err(|e| e.into_error(scope, false, false))?;
	}

The panic message caused by new_es_module

called Result::unwrap() on an Err value: Js(JsError { name: Some("SyntaxError"), message: Some("Unexpected token ':'"), stack: Some("SyntaxError: Unexpected token ':'"), cause: None, exception_message: "Uncaught SyntaxError: Unexpected token ':'", frames: [JsStackFrame { type_name: None, function_name: None, method_name: None, file_name: Some("memory://filter.ts"), line_number: Some(2), column_number: Some(42), eval_origin: None, is_top_level: None, is_eval: false, is_native: false, is_constructor: false, is_async: false, is_promise_all: false, promise_index: None }], source_line: None, source_line_frame_index: Some(0), aggregated: None })

[bartlomieju]

This method is meant to execute already transpiled code from a string source.

[taikulawo]

The bootstrap code https://github.com/denoland/roll-your-own-javascript-runtime/blob/dff7d356e5ca80256687bba21217090f24013b30/src/main.rs#L157 can load typescript seamlessly, which is a thin wrapper around load_main_es_module_from_code

[bartlomieju]

The bootstrap code https://github.com/denoland/roll-your-own-javascript-runtime/blob/dff7d356e5ca80256687bba21217090f24013b30/src/main.rs#L157 can load typescript seamlessly, which is a thin wrapper around load_main_es_module_from_code

This code uses load_main_es_module(specifier) which under the hood delegates loading to the module loader - it's not evaluating code passed as string.