fix: prevent stack overflow from cyclic reference resolution#794
Merged
Conversation
Cyclic reference targets (e.g. re-exports where A → B → A) caused `partitioner_inner` to recurse forever and blow the stack during `generate_search_index` / namespace flattening. Thread a visited-set through both recursions so a target in progress is not re-entered. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
partitioner_innerinsrc/html/partition.rs(used bycreate_partitionerandflatten_namespace) followsreference_def()targets recursively with no cycle detection. Cyclic re-exports (e.g.AreferencesBwhich referencesA) recurse forever and overflow the stack — reproduced as atokio-runtime-worker has overflowed its stackabort insidegenerate_search_index.HashSet<Location>through both recursive functions; a reference target already in progress is skipped, and is removed on unwind so sibling branches can still resolve it.Test plan
cargo buildcargo test— 155 tests pass