Add SHA256 checksum verification for downloaded binaries#521
Merged
Conversation
Verify integrity of the Deno binary (bin.dockerfile) and tini binary (alpine, ubuntu, debian, distroless) using upstream .sha256sum files. This is a requirement for docker-library/official-images inclusion. Closes #162 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The sha256sum files reference the original download filenames (e.g. deno-x86_64-unknown-linux-gnu.zip, tini-amd64), but the files were being saved with different names (deno.zip, /tini). sha256sum -c expects the referenced filename to exist, causing CI to fail. Fix by downloading files with their original names and renaming after verification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin.dockerfileusing.sha256sumfiles fromdl.deno.landalpine,ubuntu,debian,distroless) using.sha256sumfiles from tini GitHub releasesCloses #162
Test plan
bin.dockerfilefor amd64 and arm64 — verify checksum passessha256sum -cstep🤖 Generated with Claude Code