feat(BREAKING): remove import map dependency from deno_graph (#617)

Author: dsherret

Cargo.lock

@@ -1,22 +1,22 @@
 [package]
 name = "deno_graph"
 version = "0.105.0"
+authors = ["the Deno authors"]
+documentation = "https://docs.rs/deno_graph"
 edition = "2024"
-description = "Module graph analysis for deno"
 homepage = "https://deno.land/"
-repository = "https://github.com/denoland/deno_graph"
-documentation = "https://docs.rs/deno_graph"
-authors = ["the Deno authors"]
 license = "MIT"
+repository = "https://github.com/denoland/deno_graph"
+description = "Module graph analysis for deno"
 
 [workspace]
 members = ["lib"]
 
 [workspace.dependencies]
+deno_error = { version = "0.7.0", features = ["serde", "serde_json"] }
 deno_unsync = { version = "0.4.4", default-features = false }
-thiserror = "2"
-deno_error = "0.7.0"
 sys_traits = "0.1.16"
+thiserror = "2"
 
 [lib]
 name = "deno_graph"
@@ -49,16 +49,12 @@ chrono = { version = "0.4.42", default-features = false, features = ["serde"] }
 data-url = "0.3.0"
 # this is optional in order to support using parsers other than swc
 deno_ast = { version = "0.52.0", features = ["emit"], optional = true }
-deno_media_type = { version = "0.3.0", features = [
-  "decoding",
-  "data_url",
-  "module_specifier",
-] }
-deno_unsync.workspace = true
-deno_path_util = "0.6.0"
+deno_error.workspace = true
+deno_media_type = { version = "0.3.0", features = ["decoding", "data_url", "module_specifier"] }
+deno_path_util = "0.6.4"
 deno_semver = "0.9.0"
+deno_unsync.workspace = true
 futures = "0.3.26"
-import_map = "0.24.0"
 indexmap = { version = "2", features = ["serde"] }
 log = "0.4.20"
 monch = "0.5.0"
@@ -70,7 +66,6 @@ serde_json = { version = "1.0.67", features = ["preserve_order"] }
 sha2 = "^0.10.0"
 sys_traits.workspace = true
 thiserror.workspace = true
-deno_error.workspace = true
 twox-hash = { version = "1.6.3", optional = true }
 url = { version = "2.5.4", features = ["serde"] }
 wasm_dep_analyzer = "0.4.0"
@@ -80,18 +75,14 @@ deno_unsync = { workspace = true, features = ["tokio"] }
 
 [dev-dependencies]
 bincode = "1.3.3"
+deno_terminal = "0.2.0"
+env_logger = "0.11.3"
 file_test_runner = "0.7.0"
 pretty_assertions = "1.0.0"
-reqwest = { version = "0.12.4", default-features = false, features = [
-  "http2",
-  "charset",
-  "rustls-tls-webpki-roots",
-] }
+reqwest = { version = "0.12.4", default-features = false, features = ["http2", "charset", "rustls-tls-webpki-roots"] }
+sys_traits = { workspace = true, features = ["memory"] }
 tempfile = "3.4.0"
 tokio = { version = "1.10.1", features = ["macros", "rt-multi-thread", "sync"] }
-deno_terminal = "0.2.0"
-env_logger = "0.11.3"
-sys_traits = { workspace = true, features = ["memory"] }
 
 [profile.release]
 codegen-units = 1

Cargo.toml

@@ -2,8 +2,8 @@
 
 pub type ModuleSpecifier = url::Url;
 
-pub use import_map::specifier::SpecifierError;
-pub use import_map::specifier::resolve_import;
+pub use deno_path_util::SpecifierError;
+pub use deno_path_util::resolve_import;
 
 pub fn is_fs_root_specifier(url: &ModuleSpecifier) -> bool {
   if url.scheme() != "file" {

src/module_specifier.rs

@@ -469,9 +469,6 @@ pub enum ResolveError {
   Specifier(#[from] SpecifierError),
   #[class(inherit)]
   #[error(transparent)]
-  ImportMap(#[from] import_map::ImportMapError),
-  #[class(inherit)]
-  #[error(transparent)]
   Other(#[from] deno_error::JsErrorBox),
 }
 

src/source/mod.rs

@@ -56,12 +56,7 @@ TS4114 [ERROR]: This member must have an 'override' modifier because it override
   ~~~~~~~~~~~~~~~~~
     at file://<tmpdir>/collections/CiMap.ts:30:3
 
-TS2503 [ERROR]: Cannot find namespace 'NodeJS'.
- */ export default function read<T>(target: NodeJS.EventEmitter, eventMap?: {
-                                            ~~~~~~
-    at file://<tmpdir>/read.ts:78:45
-
-Found 8 errors.
+Found 7 errors.
 
 error: Type checking failed.
 

tests/specs/ecosystem/ayonli/jsext/0_7_10.test

@@ -56,12 +56,7 @@ TS4114 [ERROR]: This member must have an 'override' modifier because it override
   ~~~~~~~~~~~~~~~~~
     at file://<tmpdir>/collections/CiMap.ts:30:3
 
-TS2503 [ERROR]: Cannot find namespace 'NodeJS'.
- */ export default function read<T>(target: NodeJS.EventEmitter, eventMap?: {
-                                            ~~~~~~
-    at file://<tmpdir>/read.ts:78:45
-
-Found 8 errors.
+Found 7 errors.
 
 error: Type checking failed.
 

tests/specs/ecosystem/ayonli/jsext/0_7_11.test

@@ -56,12 +56,7 @@ TS4114 [ERROR]: This member must have an 'override' modifier because it override
   ~~~~~~~~~~~~~~~~~
     at file://<tmpdir>/collections/CiMap.ts:30:3
 
-TS2503 [ERROR]: Cannot find namespace 'NodeJS'.
- */ export default function read<T>(target: NodeJS.EventEmitter, eventMap?: {
-                                            ~~~~~~
-    at file://<tmpdir>/read.ts:66:45
-
-Found 8 errors.
+Found 7 errors.
 
 error: Type checking failed.
 

tests/specs/ecosystem/ayonli/jsext/0_7_7.test

@@ -56,12 +56,7 @@ TS4114 [ERROR]: This member must have an 'override' modifier because it override
   ~~~~~~~~~~~~~~~~~
     at file://<tmpdir>/collections/CiMap.ts:30:3
 
-TS2503 [ERROR]: Cannot find namespace 'NodeJS'.
- */ export default function read<T>(target: NodeJS.EventEmitter, eventMap?: {
-                                            ~~~~~~
-    at file://<tmpdir>/read.ts:78:45
-
-Found 8 errors.
+Found 7 errors.
 
 error: Type checking failed.
 

tests/specs/ecosystem/ayonli/jsext/0_7_8.test

@@ -56,12 +56,7 @@ TS4114 [ERROR]: This member must have an 'override' modifier because it override
   ~~~~~~~~~~~~~~~~~
     at file://<tmpdir>/collections/CiMap.ts:30:3
 
-TS2503 [ERROR]: Cannot find namespace 'NodeJS'.
- */ export default function read<T>(target: NodeJS.EventEmitter, eventMap?: {
-                                            ~~~~~~
-    at file://<tmpdir>/read.ts:78:45
-
-Found 8 errors.
+Found 7 errors.
 
 error: Type checking failed.
 

tests/specs/ecosystem/ayonli/jsext/0_8_0.test

@@ -56,12 +56,7 @@ TS4114 [ERROR]: This member must have an 'override' modifier because it override
   ~~~~~~~~~~~~~~~~~
     at file://<tmpdir>/collections/CiMap.ts:30:3
 
-TS2503 [ERROR]: Cannot find namespace 'NodeJS'.
- */ export default function read<T>(target: NodeJS.EventEmitter, eventMap?: {
-                                            ~~~~~~
-    at file://<tmpdir>/read.ts:78:45
-
-Found 8 errors.
+Found 7 errors.
 
 error: Type checking failed.