feat: add on_resolve hook to Reporter (#603)

Author: nathanwhit

src/graph.rs

@@ -4806,6 +4806,9 @@ impl<'a, 'graph> Builder<'a, 'graph> {
       name: package_req.name.clone(),
       version,
     };
+    if let Some(reporter) = &self.reporter {
+      reporter.on_resolve(package_req, &package_nv);
+    }
     self
       .graph
       .packages

src/lib.rs

@@ -179,8 +179,11 @@ mod tests {
 
   use super::*;
   use deno_error::JsErrorBox;
+  use deno_semver::package::PackageNv;
+  use deno_semver::package::PackageReq;
   use indexmap::IndexMap;
   use indexmap::IndexSet;
+  use parking_lot::Mutex;
   use pretty_assertions::assert_eq;
   use serde_json::json;
   use source::tests::MockResolver;
@@ -189,7 +192,6 @@ mod tests {
   use source::ResolutionMode;
   use source::Source;
   use source::DEFAULT_JSX_IMPORT_SOURCE_MODULE;
-  use std::cell::RefCell;
   use std::collections::BTreeMap;
 
   type Sources<'a> = Vec<(&'a str, Source<&'a str>)>;
@@ -2590,9 +2592,10 @@ export const foo = 'bar';"#,
     );
   }
 
-  #[derive(Debug)]
+  #[derive(Debug, Default)]
   struct CollectingReporter {
-    on_loads: RefCell<Vec<(ModuleSpecifier, usize, usize)>>,
+    on_loads: Mutex<Vec<(ModuleSpecifier, usize, usize)>>,
+    on_resolves: Mutex<Vec<(PackageReq, PackageNv)>>,
   }
 
   impl source::Reporter for CollectingReporter {
@@ -2602,12 +2605,19 @@ export const foo = 'bar';"#,
       modules_done: usize,
       modules_total: usize,
     ) {
-      self.on_loads.borrow_mut().push((
+      self.on_loads.lock().push((
         specifier.clone(),
         modules_done,
         modules_total,
       ));
     }
+
+    fn on_resolve(&self, req: &PackageReq, package_nv: &PackageNv) {
+      self
+        .on_resolves
+        .lock()
+        .push((req.clone(), package_nv.clone()));
+    }
   }
 
   #[tokio::test]
@@ -2661,9 +2671,7 @@ export const foo = 'bar';"#,
     );
     let root_specifier =
       ModuleSpecifier::parse("file:///a/test01.ts").expect("bad url");
-    let reporter = CollectingReporter {
-      on_loads: RefCell::new(vec![]),
-    };
+    let reporter = CollectingReporter::default();
     let mut graph = ModuleGraph::new(GraphKind::All);
     graph
       .build(

src/source/mod.rs

@@ -770,7 +770,8 @@ impl Loader for MemoryLoader {
 
 /// A trait which can be used to allow the module graph to report status events
 /// to the user.
-pub trait Reporter: fmt::Debug {
+pub trait Reporter: fmt::Debug + Send + Sync {
+  #[allow(unused_variables)]
   /// A handler that is called after each load of a module. It contains the
   /// module specifier of the module that was loaded, and the number of modules
   /// seen (total number of unique specifiers seen), and the number of modules
@@ -781,7 +782,14 @@ pub trait Reporter: fmt::Debug {
     specifier: &ModuleSpecifier,
     modules_done: usize,
     modules_total: usize,
-  );
+  ) {
+  }
+
+  #[allow(unused_variables)]
+  /// A handler that is called after each resolution of a package requirement.
+  /// It contains the package requirement and the package name and version that
+  /// was resolved.
+  fn on_resolve(&self, req: &PackageReq, package_nv: &PackageNv) {}
 }
 
 /// Resolve a media type and optionally the charset from a module specifier and