fix: set should error for invalid options

Author: dsherret

src/shell/commands/set.rs

@@ -54,8 +54,11 @@ fn execute_set(context: &mut ShellCommandContext) -> ExecuteResult {
         i += 1;
       }
     } else {
-      // Unknown argument
-      i += 1;
+      // unknown argument
+      let _ = context
+        .stderr
+        .write_line(&format!("set: invalid option: {}", arg));
+      return ExecuteResult::from_exit_code(1);
     }
   }
 

tests/integration_test.rs

@@ -2002,6 +2002,14 @@ async fn pipefail_option() {
     .assert_exit_code(1)
     .run()
     .await;
+
+  // invalid argument
+  TestBuilder::new()
+    .command("set -x")
+    .assert_stderr("set: invalid option: -x\n")
+    .assert_exit_code(1)
+    .run()
+    .await;
 }
 
 #[tokio::test]