better error handling and token caching

Author: crowlKats

auth.ts

@@ -10,7 +10,9 @@ import {
   retryLink,
   splitLink,
   TRPCClientError,
+  type TRPCLink,
 } from "@trpc/client";
+import { observable } from "@trpc/server/observable";
 import { Spinner } from "@std/cli/unstable-spinner";
 import { error } from "./util.ts";
 import token_storage from "./token_storage.ts";
@@ -19,6 +21,25 @@ import { EventSourcePolyfill } from "event-source-polyfill";
 export function createTrpcClient(deployUrl: string) {
   let storedAuth = token_storage.get();
 
+  // deno-lint-ignore no-explicit-any
+  const errorLink: TRPCLink<any> = () => {
+    return ({ next, op }) => {
+      return observable((observer) => {
+        return next(op).subscribe({
+          next(value) {
+            observer.next(value);
+          },
+          error(err) {
+            error(err.message);
+          },
+          complete() {
+            observer.complete();
+          },
+        });
+      });
+    };
+  };
+
   const transformer: TRPCCombinedDataTransformer = {
     input: {
       serialize,
@@ -35,6 +56,7 @@ export function createTrpcClient(deployUrl: string) {
   // deno-lint-ignore no-explicit-any
   return createTRPCClient<any>({
     links: [
+      errorLink,
       retryLink({
         retry({ error }) {
           if (error.message !== "Unauthorized") {

publish.ts

@@ -103,7 +103,6 @@ export async function publish(
     }
   }
   hashesSpinner.stop();
-  console.log(`${green("✔")} Generated hashes`);
 
   const trpcClient = createTrpcClient(deployUrl);
 
@@ -116,6 +115,9 @@ export async function publish(
       manifest,
     });
 
+  // doing this after we initiate the cli revision in case it fails (ie app not existing).
+  console.log(`${green("✔")} Generated hashes`);
+
   console.log(
     `You can view your application overview here:\n  ${deployUrl}/${org}/${app}`,
   );
@@ -251,6 +253,9 @@ export async function publish(
   } else {
     console.log("No files were changed, so there is nothing to upload.");
   }
+  console.log(
+    "You may now cancel this command, or wait until your domains are printed out.",
+  );
 
   const completionSpinner = new Spinner({
     message: "Awaiting revision to complete...",

token_storage.ts

@@ -1,14 +1,18 @@
+let cachedToken: string | null = null;
+
 export default {
   get(): string | null {
     // @ts-ignore deno internals
-    return Deno[Deno.internal].core.ops.op_deploy_token_get();
+    return cachedToken ??= Deno[Deno.internal].core.ops.op_deploy_token_get();
   },
   set(token: string) {
     // @ts-ignore deno internals
     Deno[Deno.internal].core.ops.op_deploy_token_set(token);
+    cachedToken = token;
   },
   remove() {
     // @ts-ignore deno internals
     Deno[Deno.internal].core.ops.op_deploy_token_delete();
+    cachedToken = null;
   },
 };