fix: stop rewriting the window global

`window` was being rewritten to `globalThis` (or `dntShim.dntGlobalThis`
when the shim proxy was used), which broke browser detection because
`typeof window === "object"` would then always be true.

`window` doesn't exist in Deno anymore, so leave it alone.

Author: dsherret

rs-lib/src/visitors/globals.rs

@@ -87,26 +87,6 @@ fn visit_children(node: Node, import_name: &str, context: &mut Context) {
     let ident_text = ident.text_fast(context.program);
 
     if is_unresolved_context {
-      // change `window` -> `globalThis`
-      if ident_text == "window" {
-        if !context.top_level_decls.contains("window")
-          && !has_ignore_comment(ident.into(), context)
-        {
-          if let Some(text_change) =
-            get_global_this_text_change(ident, import_name, context)
-          {
-            context.text_changes.push(text_change);
-            context.import_shim = true;
-          } else {
-            context.text_changes.push(TextChange {
-              range: create_range(ident.start(), ident.end(), context),
-              new_text: get_replacement_text(ident, "globalThis", context),
-            });
-          }
-        }
-        return;
-      }
-
       // check to replace globalThis
       if ident_text == "globalThis" {
         if let Some(text_change) =

rs-lib/tests/integration_test.rs

@@ -102,13 +102,6 @@ const obj = { Deno: dntShim.Deno, [dntShim.Deno]: 1, ...dntShim.Deno };"
         "\nconst obj = { globalThis: dntShim.dntGlobalThis };"
       ),
     ),
-    (
-      "const obj = { window };",
-      concat!(
-        r#"import * as dntShim from "./_dnt.shims.js";"#,
-        "\nconst obj = { window: dntShim.dntGlobalThis };"
-      ),
-    ),
     (
       concat!(
         "const decl01 = Deno;\n",
@@ -445,7 +438,6 @@ async fn transform_global_this_shim() {
       "type Test1 = typeof globalThis;",
       "type Test2 = typeof globalThis.Window;",
       "type Test3 = typeof globalThis.Deno;",
-      "type Test4 = window.Something;",
     ),
     concat!(
       r#"import * as dntShim from "./_dnt.shims.js";"#,
@@ -464,28 +456,22 @@ async fn transform_global_this_shim() {
       "type Test1 = typeof dntShim.dntGlobalThis;",
       "type Test2 = typeof globalThis.Window;",
       "type Test3 = typeof dntShim.Deno;",
-      "type Test4 = globalThis.Something;",
     ),
   )])
   .await;
 }
 
 #[tokio::test]
-async fn transform_window() {
-  assert_transforms(vec![
-    (
-      concat!("window.test = 5;", "window.Deno.test();",),
-      concat!(
-        r#"import * as dntShim from "./_dnt.shims.js";"#,
-        "\nglobalThis.test = 5;",
-        "dntShim.dntGlobalThis.Deno.test();",
-      ),
-    ),
-    (
-      // should be as-is because there's a declaration
-      "const window = {}; window.test;",
-      "const window = {}; window.test;",
-    ),
+async fn no_transform_window() {
+  // `window` is not a global in Node.js nor Deno, so leave it alone
+  // (ex. `typeof window === "object"` should stay a browser check)
+  assert_identity_transforms(vec![
+    "window.test = 5;",
+    "window.Deno.test();",
+    "const obj = { window };",
+    r#"typeof window === "object";"#,
+    "type Test = window.Something;",
+    "const window = {}; window.test;",
   ])
   .await;
 }