clean up doc template (#2712)

Co-authored-by: Phil Hawksworth <phil@deno.com>

Author: thisisjofrank

_includes/doc.tsx

@@ -2,64 +2,54 @@ import renderCommand from "./renderCommand.tsx";
 
 export const layout = "layout.tsx";
 
-export const ogImage = (data: Lume.Data) => {
-  return data.url + "/index.png";
-};
+export const ogImage = (data: Lume.Data) => `${data.url}/index.png`;
 
 export default function Doc(data: Lume.Data, helpers: Lume.Helpers) {
-  let file = data.page.sourcePath;
-  const sidebar = data.sidebar;
-  let renderedCommand = null;
-
-  if (data.command) {
-    const { rendered, toc } = renderCommand(data.command, helpers);
-    renderedCommand = rendered;
-    data.toc = toc.concat(...data.toc);
-  }
-
+  // Flags and simple derivations
+  const API_LANDING = new Set(["/api/deno/", "/api/web/", "/api/node/"]);
   const isReference = data.url.startsWith("/api/");
-  const isApiLandingPage = ["/api/deno/", "/api/web/", "/api/node/"].includes(
-    data.url,
+  const isApiLandingPage = API_LANDING.has(data.url);
+  const isExampleScript = Boolean(
+    (data.page.data.content as { type?: string })?.type,
   );
-  const isExamples = data.url.startsWith("/examples/");
-  const isExampleScript = (data.page.data.content as { type?: string })?.type;
   const isLintRule = data.url.startsWith("/lint/rules/");
-  const isHome = data.url === "/";
 
-  const hasBreadcrumbs = !isExamples && !isHome &&
-    !(isReference && !isApiLandingPage);
+  // Compute file path used by Feedback component
+  const file = isLintRule
+    ? `/lint/rules/${encodeURIComponent(data.title ?? "")}.md`
+    : data.page.sourcePath;
 
-  if (isLintRule) {
-    file = `/lint/rules/${encodeURIComponent(data.title ?? "")}.md`;
+  // Render command block and merge its TOC if present
+  let renderedCommand: unknown = null;
+  if (data.command) {
+    const { rendered, toc } = renderCommand(data.command, helpers);
+    renderedCommand = rendered;
+    data.toc = toc.concat(...data.toc);
   }
 
   function getTocCtx(
-    d: Lume.Data,
+    d: unknown,
   ): { document_navigation: unknown; document_navigation_str: string } | null {
-    const ch: unknown = (d as unknown as { children?: unknown })?.children;
-    if (ch && typeof ch === "object" && "props" in ch) {
-      const props: unknown = (ch as { props?: unknown }).props;
-      if (props && typeof props === "object" && "data" in props) {
-        const pdata: unknown = (props as { data?: unknown }).data;
-        if (pdata && typeof pdata === "object" && "toc_ctx" in pdata) {
-          const toc: unknown = (pdata as { toc_ctx?: unknown }).toc_ctx;
-          if (
-            toc && typeof toc === "object" &&
-            "document_navigation" in toc &&
-            "document_navigation_str" in toc
-          ) {
-            const t = toc as {
-              document_navigation: unknown;
-              document_navigation_str: string;
-            };
-            return t;
-          }
-        }
-      }
+    type Toc = {
+      document_navigation: unknown;
+      document_navigation_str: string;
+    };
+    const tocCtx: unknown = (d as {
+      children?: { props?: { data?: { toc_ctx?: unknown } } };
+    })?.children?.props?.data?.toc_ctx;
+    if (
+      tocCtx &&
+      typeof tocCtx === "object" &&
+      "document_navigation" in tocCtx &&
+      "document_navigation_str" in tocCtx
+    ) {
+      return tocCtx as Toc;
     }
     return null;
   }
 
+  const tocCtx = getTocCtx(data);
+
   return (
     <>
       <main
@@ -107,17 +97,12 @@ export default function Doc(data: Lume.Data, helpers: Lume.Helpers) {
           <data.comp.Feedback file={file} />
         </div>
       </main>
-      {(() => {
-        const tocCtx = getTocCtx(data);
-        return isReference && tocCtx
-          ? (
-            <data.comp.RefToc
-              documentNavigation={tocCtx.document_navigation}
-              documentNavigationStr={tocCtx.document_navigation_str}
-            />
-          )
-          : null;
-      })()}
+      {isReference && tocCtx && (
+        <data.comp.RefToc
+          documentNavigation={tocCtx.document_navigation}
+          documentNavigationStr={tocCtx.document_navigation_str}
+        />
+      )}
     </>
   );
 }