Skip to content

Commit bf05f08

Browse files
authored
refactor: upgrade to deno_graph 0.106 (#237)
1 parent 8b03045 commit bf05f08

File tree

5 files changed

+28
-30
lines changed

5 files changed

+28
-30
lines changed

Cargo.lock

Lines changed: 4 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ license = "MIT"
1111
members = ["lib"]
1212

1313
[workspace.dependencies]
14-
deno_graph = { version = "0.105.0", default-features = false }
14+
deno_graph = { version = "0.106.0", default-features = false }
1515
deno_ast = { version = "0.52.0", features = ["transpiling"] }
1616
import_map = "0.24.0"
1717
serde = "1"
@@ -71,3 +71,4 @@ reqwest = { version = "0.11.23", features = ["rustls-tls"] }
7171
jsonc-parser = { version = "0.23.0", features = ["serde"] }
7272
insta = "1.34.0"
7373
criterion = { version = "0.5", features = ["async_tokio"] }
74+

lib/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ impl Resolver for GraphResolver {
438438
if let Some(import_map) = &self.0 {
439439
import_map
440440
.resolve(specifier, &referrer_range.specifier)
441-
.map_err(ResolveError::ImportMap)
441+
.map_err(ResolveError::from_err)
442442
} else {
443443
Ok(deno_graph::resolve_import(
444444
specifier,

src/examples/builder.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ impl deno_graph::source::Resolver for Resolver {
115115
if let Some(import_map) = &self.0 {
116116
import_map
117117
.resolve(specifier, &referrer_range.specifier)
118-
.map_err(ResolveError::ImportMap)
118+
.map_err(ResolveError::from_err)
119119
} else {
120120
Ok(deno_graph::resolve_import(
121121
specifier,

src/v2.rs

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ use deno_npm::resolution::SerializedNpmResolutionSnapshotPackage;
2727
use deno_npm::resolution::ValidSerializedNpmResolutionSnapshot;
2828
use deno_semver::StackString;
2929
use deno_semver::npm::NpmPackageNvReference;
30-
use deno_semver::npm::NpmPackageReqReference;
3130
use deno_semver::package::PackageNv;
3231
use deno_semver::package::PackageNvReference;
3332
use deno_semver::package::PackageReq;
@@ -1483,13 +1482,12 @@ impl EszipV2 {
14831482
modules.insert(specifier_key.into_owned(), eszip_module);
14841483
Ok(None)
14851484
}
1486-
deno_graph::Module::Npm(_) => {
1485+
deno_graph::Module::Npm(module) => {
14871486
let Some(npm_packages) = npm_packages else {
14881487
return Ok(None);
14891488
};
14901489

1491-
let req_ref =
1492-
NpmPackageReqReference::from_specifier(module.specifier())?;
1490+
let req_ref = &module.pkg_req_ref;
14931491
let serialize_npm_snapshot = npm_snapshot.as_serialized();
14941492
let pkg_id = serialize_npm_snapshot.root_packages.get(req_ref.req())
14951493
.ok_or_else(|| anyhow::anyhow!("Could not resolve package req '{}' from graph because it was missing in the provided npm snapshot.", req_ref.req()))?;
@@ -2111,12 +2109,12 @@ mod tests {
21112109
self
21122110
.0
21132111
.resolve(specifier, &referrer_range.specifier)
2114-
.map_err(ResolveError::ImportMap)
2112+
.map_err(ResolveError::from_err)
21152113
}
21162114
}
21172115

21182116
macro_rules! mock_npm_resolver {
2119-
($resolver_name:ident { $($req_name:literal => $nv:literal),+$(,)?} ) => {
2117+
($resolver_name:ident { $($req_name:literal),+$(,)?} ) => {
21202118
#[derive(Debug)]
21212119
struct $resolver_name;
21222120

@@ -2132,7 +2130,7 @@ mod tests {
21322130
results: package_reqs
21332131
.iter()
21342132
.map(|req| match &*req.name {
2135-
$($req_name => Ok(PackageNv::from_str($nv).unwrap())),+,
2133+
$($req_name => Ok(())),+,
21362134
_ => unreachable!(),
21372135
})
21382136
.collect(),
@@ -3228,9 +3226,9 @@ mod tests {
32283226

32293227
mock_npm_resolver!(
32303228
NpmResolver {
3231-
"a" => "a@1.2.2",
3232-
"d" => "d@5.0.0",
3233-
"other" => "other@99.99.99",
3229+
"a",
3230+
"d",
3231+
"other",
32343232
}
32353233
);
32363234

@@ -3289,9 +3287,9 @@ mod tests {
32893287
);
32903288
let npm_snapshot = SerializedNpmResolutionSnapshot {
32913289
root_packages: root_pkgs(&[
3292-
("a@1.2.2", "a@1.2.2"),
3293-
("d@5.0.0", "d@5.0.0"),
3294-
("other@99.99.99", "other@99.99.99"),
3290+
("a@^1.2", "a@1.2.2"),
3291+
("d", "d@5.0.0"),
3292+
("other", "other@99.99.99"),
32953293
]),
32963294
packages: Vec::from([
32973295
new_package("a@1.2.2", &[]),
@@ -3371,9 +3369,9 @@ mod tests {
33713369

33723370
mock_npm_resolver!(
33733371
NpmResolver {
3374-
"a" => "a@1.2.2",
3375-
"d" => "d@5.0.0",
3376-
"other" => "other@99.99.99",
3372+
"a",
3373+
"d",
3374+
"other",
33773375
}
33783376
);
33793377

@@ -3449,10 +3447,10 @@ mod tests {
34493447
);
34503448
let npm_snapshot = SerializedNpmResolutionSnapshot {
34513449
root_packages: root_pkgs(&[
3452-
("a@1.2.2", "a@1.2.2"),
3453-
("d@5.0.0", "d@5.0.0"),
3450+
("a@^1.2", "a@1.2.2"),
3451+
("d", "d@5.0.0"),
34543452
("z@0.1.2", "z@0.1.2"),
3455-
("other@99.99.99", "other@99.99.99"),
3453+
("other", "other@99.99.99"),
34563454
]),
34573455
packages: Vec::from([
34583456
new_package("a@1.2.2", &[]),
@@ -3604,9 +3602,9 @@ mod tests {
36043602

36053603
mock_npm_resolver!(
36063604
NpmResolver {
3607-
"a" => "a@1.2.2",
3608-
"d" => "d@5.0.0",
3609-
"other" => "other@99.99.99",
3605+
"a",
3606+
"d",
3607+
"other",
36103608
}
36113609
);
36123610

0 commit comments

Comments
 (0)