fix: remove unused namedExports logic

Author: CertainLach

packages/plugin-vite/src/plugins/patches/commonjs.ts

@@ -189,19 +189,14 @@ export function cjsPlugin(
             );
           }
 
-          const exportNamed = new Map<string, string>();
-
           const idExports: types.ExportSpecifier[] = [];
           for (const name of exported) {
             if (name === "default") {
-              exportNamed.set(name, name);
               continue;
             }
 
             const id = path.scope.generateUidIdentifier(name);
 
-            exportNamed.set(id.name, name);
-
             path.pushContainer(
               "body",
               t.variableDeclaration(
@@ -227,7 +222,7 @@ export function cjsPlugin(
             );
           }
 
-          if (exportNamed.size > 0 || exportedNs.size > 0 || hasEsModule) {
+          if (exported.size > 0 || exportedNs.size > 0 || hasEsModule) {
             const id = path.scope.generateUidIdentifier("__default");
 
             path.pushContainer(
@@ -244,10 +239,18 @@ export function cjsPlugin(
               t.ifStatement(
                 t.logicalExpression(
                   "&&",
-                  t.binaryExpression(
-                    "===",
-                    t.unaryExpression("typeof", t.identifier("exports")),
-                    t.stringLiteral("object"),
+                  t.logicalExpression(
+                    "&&",
+                    t.binaryExpression(
+                      "===",
+                      t.unaryExpression("typeof", t.identifier("exports")),
+                      t.stringLiteral("object"),
+                    ),
+                    t.binaryExpression(
+                      "!==",
+                      t.identifier("exports"),
+                      t.nullLiteral(),
+                    ),
                   ),
                   t.binaryExpression(
                     "in",
@@ -284,10 +287,18 @@ export function cjsPlugin(
                 t.ifStatement(
                   t.logicalExpression(
                     "&&",
-                    t.binaryExpression(
-                      "===",
-                      t.unaryExpression("typeof", t.identifier("exports")),
-                      t.stringLiteral("object"),
+                    t.logicalExpression(
+                      "&&",
+                      t.binaryExpression(
+                        "===",
+                        t.unaryExpression("typeof", t.identifier("exports")),
+                        t.stringLiteral("object"),
+                      ),
+                      t.binaryExpression(
+                        "!==",
+                        t.identifier("exports"),
+                        t.nullLiteral(),
+                      ),
                     ),
                     t.unaryExpression(
                       "!",
@@ -694,6 +705,7 @@ export function cjsPlugin(
               state.set(HAS_ES_MODULE, true);
             } else if (left.isMemberExpression()) {
               if (isModuleExports(t, left.node)) {
+                // Should always try to create synthetic default export in this case.
                 exported.add("default");
 
                 if (t.isObjectExpression(expr.node.right)) {

packages/plugin-vite/src/plugins/patches/commonjs_test.ts

@@ -27,7 +27,7 @@ Object.defineProperty(module, "exports", {
 });`;
 
 const DEFAULT_EXPORT = `let _default;
-if (typeof exports === "object" && "default" in exports) {
+if (typeof exports === "object" && exports !== null && "default" in exports) {
   _default = exports.default;
 } else {
   _default = exports;
@@ -366,7 +366,7 @@ Deno.test("commonjs - detect esbuild shims", () => {
 import * as _ns from "./globalThis";
 export * from "./globalThis";
 ${DEFAULT_EXPORT}
-if (typeof exports === "object" && !("default" in exports)) for (var _k in _ns) if (_k !== "default" && _k !== "__esModule" && Object.prototype.hasOwnProperty.call(_ns, _k)) _default[_k] = _ns[_k];
+if (typeof exports === "object" && exports !== null && !("default" in exports)) for (var _k in _ns) if (_k !== "default" && _k !== "__esModule" && Object.prototype.hasOwnProperty.call(_ns, _k)) _default[_k] = _ns[_k];
 ${DEFAULT_EXPORT_END}`,
   });
 });
@@ -508,7 +508,7 @@ Object.defineProperty(exports, "__esModule", {
 });
 export * from "./node";
 ${DEFAULT_EXPORT}
-if (typeof exports === "object" && !("default" in exports)) for (var _k in _ns) if (_k !== "default" && _k !== "__esModule" && Object.prototype.hasOwnProperty.call(_ns, _k)) _default[_k] = _ns[_k];
+if (typeof exports === "object" && exports !== null && !("default" in exports)) for (var _k in _ns) if (_k !== "default" && _k !== "__esModule" && Object.prototype.hasOwnProperty.call(_ns, _k)) _default[_k] = _ns[_k];
 ${DEFAULT_EXPORT_END}
 ${EXPORT_ES_MODULE}`,
   });