Docs look really flashy

[lishaduck]

When opening the docs, there's a flash of dark mode before it switches, following #2820. Would it be possible to default to system colors, and use custom ones as a fallback? That should fix it.

Tailwind's docs about it are here. I don't love that solution, but 🤷‍♂

[lishaduck]

Here's a video (trimmed to reduce the chance of seizures :)(:

Screen.Recording.2025-02-10.at.11.55.22.AM.mov

[theoriginalstove]

What browser and operating system are you using? I don't notice any flashiness on initial page loads to dark mode when visiting the docs with Zen or Chrome on macOS. It might have also been fixed already lol

[CAYdenberg]

The OP says there is a flash of dark mode, meaning given you are not in dark mode, it briefly flashes in dark mode and then switches to light.

Try disabling JavaScript 😃 In that case dark mode persists.

[theoriginalstove]

The OP says there is a flash of dark mode, meaning given you are not in dark mode, it briefly flashes in dark mode and then switches to light.

Try disabling JavaScript 😃 In that case dark mode persists.

Doh 🤦‍♂️, you're right. I was trying to recreate it with the wrong steps lol.

[CAYdenberg]

Suggest editing the title to: "Docs load in dark mode by default; clientside JavaScript is required to restore light mode". Given progressive enhancement is the key advantage of Fresh over competing frameworks, that would ideally be fixed.

[lishaduck]

What browser and operating system are you using? I don't notice any flashiness on initial page loads to dark mode when visiting the docs with Zen or Chrome on macOS.

Chrome & Zen, macOS :)

[lishaduck]

@marvinhagemeister, that doesn't entirely fix the issue. Now the issue is the same, it's just inverted.
It's less noticeable for sure, though.

[marvinhagemeister]

I'm not able to reproduce the issue on any of my machines or browser's I've tried. There is no flashing for me.

[CAYdenberg]

I can detect it in Firefox about half the time.

If you turn off JavaScript, dark mode does not work. Which means that technically the flashing is "always" happening, as in the page renders serverside in light mode and then switches to dark.

In a way, this cuts to the philosophy of Fresh. When an island affects the rendering of the entire page, then the island must load and execute before the "correct" state of the page is reached. OTOH, the "correct" fix (session cookie) would mean rewriting this feature, and it seems acceptable that dark mode counts as an enhanced experience.

Perhaps a longer term issue should be opened - esp. if Fresh v2 will mean a substantial redesign of the docs (no use fixing it for v1). If the core team wants the fix, I'd be interested in working on this PR myself as it's somewhat instructive to Fresh's core capabilities (as in, true SSR and progressive enhancement means going back to session cookies in certain circumstances instead of leaning on localStorage for everything).