Rolling to V8 14.4 (#1889)

Co-authored-by: denobot <33910674+denobot@users.noreply.github.com>

Author: devsnek

.gitmodules

@@ -55,3 +55,6 @@
 [submodule "third_party/rust"]
 	path = third_party/rust
 	url = https://chromium.googlesource.com/chromium/src/third_party/rust
+[submodule "tools/win"]
+	path = tools/win
+	url = https://chromium.googlesource.com/chromium/src/tools/win

Cargo.lock

@@ -71,6 +71,7 @@ exclude = [
   "third_party/fp16/src/test",
   "third_party/fast_float/src/tests",
   "tools/clang",
+  "tools/win",
   "v8/ChangeLog",
   "v8/benchmarks/",
   "v8/docs/",
@@ -81,6 +82,7 @@ exclude = [
   "!.gn",
   "!BUILD.gn",
   "!tools/clang/scripts/update.py",
+  "!tools/win/DebugVisualizers",
   "!v8/test/torque/test-torque.tq",
   "!v8/tools/gen-postmortem-metadata.py",
   "!v8/tools/gen-v8-gn.py",
@@ -107,7 +109,7 @@ v8_enable_v8_checks = []
 [dependencies]
 bitflags = "2.5"
 paste = "1.0"
-temporal_capi = { version = "0.1.0", features = ["zoneinfo64"] }
+temporal_capi = { version = "0.1.2", features = ["zoneinfo64"] }
 
 [build-dependencies]
 miniz_oxide = "0.8.8"

Cargo.toml

@@ -1,6 +1,6 @@
 # Rusty V8 Binding
 
-V8 Version: 14.2.231.17
+V8 Version: 14.4.258.6
 
 [![ci](https://github.com/denoland/rusty_v8/workflows/ci/badge.svg?branch=main)](https://github.com/denoland/rusty_v8/actions)
 [![crates](https://img.shields.io/crates/v/v8.svg)](https://crates.io/crates/v8)

README.md

@@ -1127,35 +1127,18 @@ int v8__String__Utf8Length(const v8::String& self, v8::Isolate* isolate) {
   return self.Utf8LengthV2(isolate);
 }
 
-int v8__String__Write(const v8::String& self, v8::Isolate* isolate,
-                      uint16_t* buffer, int start, int length, int options) {
-  return self.Write(isolate, buffer, start, length, options);
-}
-
 void v8__String__Write_v2(const v8::String& self, v8::Isolate* isolate,
                           uint32_t offset, uint32_t length, uint16_t* buffer,
                           int flags) {
   return self.WriteV2(isolate, offset, length, buffer, flags);
 }
 
-int v8__String__WriteOneByte(const v8::String& self, v8::Isolate* isolate,
-                             uint8_t* buffer, int start, int length,
-                             int options) {
-  return self.WriteOneByte(isolate, buffer, start, length, options);
-}
-
 void v8__String__WriteOneByte_v2(const v8::String& self, v8::Isolate* isolate,
                                  uint32_t offset, uint32_t length,
                                  uint8_t* buffer, int flags) {
   return self.WriteOneByteV2(isolate, offset, length, buffer, flags);
 }
 
-int v8__String__WriteUtf8(const v8::String& self, v8::Isolate* isolate,
-                          char* buffer, int length, int* nchars_ref,
-                          int options) {
-  return self.WriteUtf8(isolate, buffer, length, nchars_ref, options);
-}
-
 size_t v8__String__WriteUtf8_v2(const v8::String& self, v8::Isolate* isolate,
                                 char* buffer, size_t capacity, int flags,
                                 size_t* processed_characters_return) {
@@ -3806,8 +3789,8 @@ void v8__CompiledWasmModule__DELETE(v8::CompiledWasmModule* self) {
 extern "C" {
 
 size_t icu_get_default_locale(char* output, size_t output_len) {
-  const icu_74::Locale& default_locale = icu::Locale::getDefault();
-  icu_74::CheckedArrayByteSink sink(output, static_cast<uint32_t>(output_len));
+  const icu_77::Locale& default_locale = icu::Locale::getDefault();
+  icu_77::CheckedArrayByteSink sink(output, static_cast<uint32_t>(output_len));
   UErrorCode status = U_ZERO_ERROR;
   default_locale.toLanguageTag(sink, status);
   assert(status == U_ZERO_ERROR);

build

@@ -5,7 +5,7 @@ use std::ffi::CString;
 unsafe extern "C" {
   fn icu_get_default_locale(output: *mut char, output_len: usize) -> usize;
   fn icu_set_default_locale(locale: *const char);
-  fn udata_setCommonData_74(this: *const u8, error_code: *mut i32);
+  fn udata_setCommonData_77(this: *const u8, error_code: *mut i32);
 }
 
 /// This function bypasses the normal ICU data loading process and allows you to force ICU's system
@@ -42,10 +42,10 @@ unsafe extern "C" {
 /// functionality for application data.
 // TODO(ry) Map error code to something useful.
 #[inline(always)]
-pub fn set_common_data_74(data: &'static [u8]) -> Result<(), i32> {
+pub fn set_common_data_77(data: &'static [u8]) -> Result<(), i32> {
   let mut error_code = 0i32;
   unsafe {
-    udata_setCommonData_74(data.as_ptr(), &mut error_code);
+    udata_setCommonData_77(data.as_ptr(), &mut error_code);
   }
   if error_code == 0 {
     Ok(())

buildtools

@@ -8,7 +8,6 @@ use crate::support::Opaque;
 use crate::support::SharedPtr;
 use crate::support::UniqueRef;
 use crate::support::char;
-use crate::support::int;
 use crate::support::intptr_t;
 
 use std::any::Any;
@@ -114,19 +113,6 @@ impl CreateParams {
     self
   }
 
-  /// The following parameters describe the offsets for addressing type info
-  /// for wrapped API objects and are used by the fast C API
-  /// (for details see v8-fast-api-calls.h).
-  pub fn embedder_wrapper_type_info_offsets(
-    mut self,
-    embedder_wrapper_type_index: int,
-    embedder_wrapper_object_index: int,
-  ) -> Self {
-    self.raw.embedder_wrapper_type_index = embedder_wrapper_type_index;
-    self.raw.embedder_wrapper_object_index = embedder_wrapper_object_index;
-    self
-  }
-
   /// Configures the constraints with reasonable default values based on the
   /// provided lower and upper bounds.
   ///
@@ -217,8 +203,6 @@ struct CreateParamAllocations {
 #[test]
 fn create_param_defaults() {
   let params = CreateParams::default();
-  assert_eq!(params.raw.embedder_wrapper_type_index, -1);
-  assert_eq!(params.raw.embedder_wrapper_object_index, -1);
   assert!(params.raw.allow_atomics_wait);
 }
 
@@ -238,8 +222,6 @@ pub(crate) mod raw {
     pub array_buffer_allocator_shared: SharedPtr<ArrayBufferAllocator>,
     pub external_references: *const intptr_t,
     pub allow_atomics_wait: bool,
-    pub embedder_wrapper_type_index: int,
-    pub embedder_wrapper_object_index: int,
     _fatal_error_handler: *const Opaque, // FatalErrorCallback
     _oom_error_handler: *const Opaque,   // OOMErrorCallback
     pub cpp_heap: *const Heap,