Commit 5b42bdd
committed
fix(locker): remove unnecessary Enter/Exit in Locker::new()
The Enter+Exit calls before Locker::Initialize() were a no-op.
The C++ Locker only checks IsLockedByCurrentThread() and
RestoreThread(), neither of which depends on the entry stack.
top_level_ is always true in our usage (no Locker/Unlocker nesting).
Also fix incorrect doc comments claiming the isolate must be in
"entered" state for raw::Locker::init().1 parent de789a7 commit 5b42bdd
2 files changed
+3
-33
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2533 | 2533 | | |
2534 | 2534 | | |
2535 | 2535 | | |
2536 | | - | |
2537 | | - | |
2538 | | - | |
2539 | | - | |
2540 | | - | |
2541 | 2536 | | |
2542 | 2537 | | |
2543 | 2538 | | |
2544 | 2539 | | |
2545 | 2540 | | |
2546 | | - | |
2547 | | - | |
2548 | | - | |
2549 | | - | |
2550 | | - | |
2551 | | - | |
2552 | | - | |
2553 | | - | |
2554 | | - | |
2555 | | - | |
2556 | | - | |
2557 | 2541 | | |
2558 | 2542 | | |
2559 | 2543 | | |
2560 | 2544 | | |
2561 | 2545 | | |
2562 | 2546 | | |
2563 | | - | |
2564 | | - | |
2565 | | - | |
2566 | | - | |
2567 | | - | |
2568 | | - | |
2569 | | - | |
2570 | | - | |
2571 | | - | |
2572 | | - | |
2573 | 2547 | | |
2574 | | - | |
2575 | | - | |
2576 | | - | |
2577 | | - | |
| 2548 | + | |
2578 | 2549 | | |
2579 | 2550 | | |
2580 | 2551 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
236 | 236 | | |
237 | 237 | | |
238 | 238 | | |
239 | | - | |
240 | | - | |
| 239 | + | |
241 | 240 | | |
242 | 241 | | |
243 | 242 | | |
| |||
278 | 277 | | |
279 | 278 | | |
280 | 279 | | |
281 | | - | |
| 280 | + | |
282 | 281 | | |
283 | 282 | | |
284 | 283 | | |
| |||
0 commit comments