feat: add bindings for ModuleRequest.get_phase() (#1881)

Co-authored-by: Nayeem Rahman <nayeemrmn99@gmail.com>

Author: bartlomieju

src/binding.cc

@@ -3380,6 +3380,11 @@ const v8::String* v8__ModuleRequest__GetSpecifier(
   return local_to_ptr(self.GetSpecifier());
 }
 
+v8::ModuleImportPhase v8__ModuleRequest__GetPhase(
+    const v8::ModuleRequest& self) {
+  return self.GetPhase();
+}
+
 int v8__ModuleRequest__GetSourceOffset(const v8::ModuleRequest& self) {
   return self.GetSourceOffset();
 }

src/module.rs

@@ -12,6 +12,7 @@ use crate::Object;
 use crate::String;
 use crate::UnboundModuleScript;
 use crate::Value;
+use crate::isolate::ModuleImportPhase;
 use crate::isolate::RealIsolate;
 use crate::scope::GetIsolate;
 use crate::scope::PinScope;
@@ -255,6 +256,9 @@ unsafe extern "C" {
   fn v8__ModuleRequest__GetSpecifier(
     this: *const ModuleRequest,
   ) -> *const String;
+  fn v8__ModuleRequest__GetPhase(
+    this: *const ModuleRequest,
+  ) -> ModuleImportPhase;
   fn v8__ModuleRequest__GetSourceOffset(this: *const ModuleRequest) -> int;
   fn v8__ModuleRequest__GetImportAttributes(
     this: *const ModuleRequest,
@@ -568,6 +572,11 @@ impl ModuleRequest {
     unsafe { Local::from_raw(v8__ModuleRequest__GetSpecifier(self)) }.unwrap()
   }
 
+  /// Returns the module import phase for this ModuleRequest.
+  #[inline(always)]
+  pub fn get_phase(&self) -> ModuleImportPhase {
+    unsafe { v8__ModuleRequest__GetPhase(self) }
+  }
   /// Returns the source code offset of this module request.
   /// Use Module::source_offset_to_location to convert this to line/column numbers.
   #[inline(always)]

tests/test_api.rs

@@ -4898,6 +4898,7 @@ fn module_instantiation_failures1() {
     )
     .unwrap();
     assert_eq!("./foo.js", mr1.get_specifier().to_rust_string_lossy(scope));
+    assert_eq!(v8::ModuleImportPhase::kEvaluation, mr1.get_phase());
     let loc = module.source_offset_to_location(mr1.get_source_offset());
     assert_eq!(0, loc.get_line_number());
     assert_eq!(7, loc.get_column_number());
@@ -4908,6 +4909,7 @@ fn module_instantiation_failures1() {
     )
     .unwrap();
     assert_eq!("./bar.js", mr2.get_specifier().to_rust_string_lossy(scope));
+    assert_eq!(v8::ModuleImportPhase::kEvaluation, mr1.get_phase());
     let loc = module.source_offset_to_location(mr2.get_source_offset());
     assert_eq!(1, loc.get_line_number());
     assert_eq!(15, loc.get_column_number());